Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp639897pxu; Wed, 7 Oct 2020 11:51:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw55gTuA77sssLIrJ0AcFwfYsXdhcsFwd/lfl9lPjoaFvlf73fmuzJJkxFmLc75TBwTNyJZ X-Received: by 2002:a05:6402:699:: with SMTP id f25mr5012358edy.372.1602096678723; Wed, 07 Oct 2020 11:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602096678; cv=none; d=google.com; s=arc-20160816; b=IicmgRlT4mbPL6EIcRBTxKBPM4xG53UeBlFYfdhZKqAjNy7WKuvMDIMPiFMFlg2tIJ rOE/1LqEL+1T6JKwS/c6mTutlCGaTws+6q6WlzCVjN7s0ty1OHY21g23t1HaYpmBQeGp ttczlzdHfgc5JVvtHjAEr0YEanXSnpwGcAmPJR7Dw8bSakoAwl/luEnm5/m/JyRrADjb zd8ShdZ+rgXRRR1Jrb1qtN9ndXor9+WNviAiOiNE9CWlHadBEup8nLXSz7WRyZ4+Jk9G XnNgRkVAmTlNHZDQAaapbj5qk9lX5XZ+RGfr6A/wEaUcTNVdhpG318tGIgXXbyHIn4/8 uN5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=blJZdod8zk/hTt6aNFQh+ol0gh1a78kUUXD+guPskI4=; b=jmGqOLnd49sLT5B1eYfCiMfiPK1vDb8mDM5pTk7I2XzJQEHqgJcpG7FHljCsRupLfC GL5CLU2F9SmIkF4Nbghy/eFYvuROyYtY8wj+h864bgbyiX25DmouUi6Ilhtx5e08O2R4 +gNVu47GoUHiFjS2gwoVE1oc6yt52JoDfUqpZB3QVKWxC0TTgQiUs28L0eI7S3wNqwEb arEP+rvxeIEQotMQozpJ6Sz9Ogu9Ug1RFyUF/ZS8dvYgaixBjvxDVAprsgXz4+f3jiIL wwuoPjpbtJjxd8zyLxpZqqSfOpAGWPjMkf1g7ElxouwuzEqLgDZpPlIl6w2ULYtyS1BF IFSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="FXhd/ekf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y22si1916872edt.51.2020.10.07.11.50.54; Wed, 07 Oct 2020 11:51:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b="FXhd/ekf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbgJGSrI (ORCPT + 99 others); Wed, 7 Oct 2020 14:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgJGSrI (ORCPT ); Wed, 7 Oct 2020 14:47:08 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42F62C0613D3 for ; Wed, 7 Oct 2020 11:47:08 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id s7so4049968qkh.11 for ; Wed, 07 Oct 2020 11:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=blJZdod8zk/hTt6aNFQh+ol0gh1a78kUUXD+guPskI4=; b=FXhd/ekfXs6fh3cll2LP8DfZTMZ6v7gCpfAUIVVfE1B0U7VAQPIBKxkhfc1dFnYq82 Kn+0XgvAM0ZBWredbpGcw0ytLSBsmbdkDGp0d+KMnNGmIEd0csrhxJ9+3u41TCl493tC qoy8IibKfAQBUMznmwxuOWwggfytiLaCOIvMZb5U54saVhW+IJeIoldKHp1JhktgI1fb dTZmieJYDuht9kp7PCFRN7wXqTnaAEzHkQzHVBm8ar/Bjnd8Q7KMUa8aVJVvWcZ/h3MJ RvoONyk7Z54SWNZEGjCpat5nQxlJo0thAT/kABWJLN0ZoyCZkh1K7GW3tSI0B90Pau7f OT8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=blJZdod8zk/hTt6aNFQh+ol0gh1a78kUUXD+guPskI4=; b=QuFsQMNz2guV92wgBMgQsPddJOodmOuTCXbXn4N1sphElAIqOgHxaJm3KQSslF8FJP rtt+8urN/vKXTAS9Wn/A6sUpUyoQmDqhA2cxXhaByNli/G8ebxlnylK9eOXPG9c+diDE xdo+8FjEb7lAxBS1AM1YjXHkVKs5zakJBjh+csYEbl62AFEXr0DoWh3uvyeN9WLW4Uz+ gnMp+qdKw0ugDzQSt9lIEWHSH8S7MJwe3m8aSkXxakhpZgryl0XfT81p43gg0YCSl22C GY0h5OUGImnBRDigy3SaKSl+BH+f4dKnGFxJNqhTU1ukbNo2arcQZ6Yxd77Rdb9Rmq3U JioA== X-Gm-Message-State: AOAM533thfVHmHF+qc4NQ5Lc6cHrYw6MpoKXGm6b98LU/J/cBbKEtkkA xCl9nZkmo5uR/P4MjdWIHeJS1w== X-Received: by 2002:a05:620a:244e:: with SMTP id h14mr4456465qkn.348.1602096427480; Wed, 07 Oct 2020 11:47:07 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id o2sm2032427qkk.42.2020.10.07.11.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 11:47:06 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kQESv-001Elc-Ob; Wed, 07 Oct 2020 15:47:05 -0300 Date: Wed, 7 Oct 2020 15:47:05 -0300 From: Jason Gunthorpe To: Daniel Vetter Cc: DRI Development , LKML , kvm@vger.kernel.org, Linux MM , Linux ARM , linux-samsung-soc , "open list:DMA BUFFER SHARING FRAMEWORK" , linux-s390@vger.kernel.org, Daniel Vetter , Kees Cook , Dan Williams , Andrew Morton , John Hubbard , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Jan Kara , Alex Williamson , Cornelia Huck Subject: Re: [PATCH 13/13] vfio/type1: Mark follow_pfn as unsafe Message-ID: <20201007184705.GY5177@ziepe.ca> References: <20201007164426.1812530-1-daniel.vetter@ffwll.ch> <20201007164426.1812530-14-daniel.vetter@ffwll.ch> <20201007173911.GX5177@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 08:14:06PM +0200, Daniel Vetter wrote: > Hm, but wouldn't need that the semi-nasty vma_open trick to make sure > that vma doesn't untimely disappear? Or is the idea to look up the > underlying vfio object, and refcount that directly? Ah, the patches Alex was working on had the refcount I think, it does need co-ordination across multiple VFIO instances IIRC. At least a simple check would guarentee we only have exposed PCI BAR pages which is not as bad security wise as the other stuff. Jason