Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp660710pxu; Wed, 7 Oct 2020 12:26:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjK8YRWgly7OL2jfCf3IHriAeCCdnU08z8XU4NGBvOdCjR3RKLlwDez9OEfZLlst0PSGxg X-Received: by 2002:a50:c05b:: with SMTP id u27mr5112181edd.290.1602098769859; Wed, 07 Oct 2020 12:26:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602098769; cv=none; d=google.com; s=arc-20160816; b=d77OLlyQiWg+CTS+74kk8uk3s+JqeI8v073QkrVeVF374ZQSj8Ut5rRqnya/YEctaZ ejRfvKy7XGzZLJtVJQJCvLX5BZfKrPRS8V2xbj8eBku/iCiZPHbBvRiS453VESMmrpJU ncVTh198KElxWa0qkrZ6yOgRJMXzPYZdL/EpLmLE17YzBJSVk57x6/5SPefglIwMDcNw XQKbQDX/nTc3HG1ks4c1/TGdsH4kuAfMLYFMHCqQludqNFRGZGR0CUBFk2CJBpMYLy2O 5OdU11+vEchovw301lR6VmFMVmZcwV5N42ByXw57ONBY1vyERiAli1xQT6XXpUMaxTsF yoZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=rrKteRViA4vxSNBUsWnAhe7ROJCIJod5xGAgtVlXXL0=; b=zy++t7TlMNpgz2Ivkx4c3EzGhLIN6hIX4zzibd2GO4sWnpt01B2lxfhpOmCfZybdnc BAB/wF7wufya8iG243RKlCTxBrPzXAPdVhiwVPnVP/AixV6j0KbllAtRJCXXpE7KxrML TluyeOItWXt8tG1PATOJDDl57mPrFfxflxtBvZVyJzWEPT1lqdwxB1mt1v7rbfyNbWoF s1hMcUkZPceo2Y39Z5ej2vzZlpaWlNX41CF8Ob/bm+mtMwP2Bdb9BH8G1sQKwVsou1tS JE8k8zey4ve93sa/eGicrvBMQD8Fywfmgx9+3OHLflUlPAf/F1ahsxZ8rZl4Uyugup1k ERXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=cqdVnGSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=marvell.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y100si2400684ede.186.2020.10.07.12.25.46; Wed, 07 Oct 2020 12:26:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@marvell.com header.s=pfpt0220 header.b=cqdVnGSG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=marvell.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbgJGRFM (ORCPT + 99 others); Wed, 7 Oct 2020 13:05:12 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:55700 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726041AbgJGRFL (ORCPT ); Wed, 7 Oct 2020 13:05:11 -0400 Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 097H07H6028709; Wed, 7 Oct 2020 10:05:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : in-reply-to : message-id : references : mime-version : content-type; s=pfpt0220; bh=rrKteRViA4vxSNBUsWnAhe7ROJCIJod5xGAgtVlXXL0=; b=cqdVnGSG46S22OXunmVF839Tq+QCBTA4dyAkQT//o++COb2Ly6Tl1bBjlmSom1hnom0x OThMdm1S+jfpBnGJIHqwMMh8jxyXIE3caQ4sUpzdF8YXIn3Hz5ImX0BcJJbr3VxB/qoO RDVyhMo7mLePIMErsb4jet8u+sa7R7EfPc1tne5Y6d5Ol24vTmsvdZHKA7nWzmIjyBPi GZOWoPfBSJpsM4+JiJdgf+jmQCwcRsu4l3cwEYGtaVqrbJiUiHGjbwdsQzVPgQ3uNZXB DyCUPRWhmX3jwgICdTGYX9JNXnsbPEGiuOFGFbJhL6HjkFLUOTtavu6RoDp6bTlIUopL 5w== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 33xrtnmy0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 07 Oct 2020 10:05:07 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 10:05:05 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Oct 2020 10:05:05 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 7 Oct 2020 10:05:06 -0700 Received: from irv1user01.caveonetworks.com (unknown [10.104.116.179]) by maili.marvell.com (Postfix) with ESMTP id D7A303F703F; Wed, 7 Oct 2020 10:05:05 -0700 (PDT) Received: from localhost (aeasi@localhost) by irv1user01.caveonetworks.com (8.14.4/8.14.4/Submit) with ESMTP id 097H556M023986; Wed, 7 Oct 2020 10:05:05 -0700 X-Authentication-Warning: irv1user01.caveonetworks.com: aeasi owned process doing -bs Date: Wed, 7 Oct 2020 10:05:05 -0700 From: Arun Easi X-X-Sender: aeasi@irv1user01.caveonetworks.com To: Daniel Wagner CC: Nilesh Javali , , Subject: Re: [PATCH] qla2xxx: Do not consume srb greedily In-Reply-To: <20200929073802.18770-1-dwagner@suse.de> Message-ID: References: <20200929073802.18770-1-dwagner@suse.de> User-Agent: Alpine 2.21.9999 (LRH 334 2019-03-29) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-07_10:2020-10-07,2020-10-07 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2020, 12:38am, Daniel Wagner wrote: > qla2xx_process_get_sp_from_handle() will clear the slot which the > current srb is stored. So this function has a side effect. Therefore, > we can't use it in qla24xx_process_mbx_iocb_response() to check > for consistency and later again in qla24xx_mbx_iocb_entry(). > > Let's move the consistency check directly into > qla24xx_mbx_iocb_entry() and avoid the double call or any open coding > of the qla2xx_process_get_sp_from_handle() functionality. > > Fixes: 31a3271ff11b ("scsi: qla2xxx: Handle incorrect entry_type entries") > Signed-off-by: Daniel Wagner That was a nasty one, good that you caught it soon. Reviewed-by: Arun Easi Regards, -Arun