Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp682148pxu; Wed, 7 Oct 2020 13:02:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4lf0zYYM54aQDTkYCbRnkWO7eVZqcJMQrAwkAwCu86740vhzNye0XZJ0VzbB3eaRBuV0P X-Received: by 2002:a17:906:bfe2:: with SMTP id vr2mr1955213ejb.248.1602100959932; Wed, 07 Oct 2020 13:02:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602100959; cv=none; d=google.com; s=arc-20160816; b=jq/DdovRrAUU6vfVTEYEkAB0r6c6cM1S2boKUp+miSeO8GyqTgkFRl/dfStrjYDdr9 98jDlI0UgSmZBWWyIR+J16nQNTR7kvas4AgumM/VoRi9kEceC2Jg/1pQS1D8jSZ6qqvx e2P+EtB9/8WcDsZ1mW7tv6wZVCm6Ppl6lP4iwTy176Il3qMTGtoMg/Fib0WZWfgVh1+y few4aEQK1HV1XFygtuSuqboD2h6WVsld7mxXdPlkHz+p/o9wQPDkC/iJ0fKI8VqJfLyz J0OKaCX7mTiPoH/DO9ibYTDhLDsNbzDfUy+o7T14p2L29Tm4ufL4wKuQuZTllICF5okW eTZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q9WdYuy1sGj1mEU3lvIha9DHOrDzcXvSqugIUJaui88=; b=e8MJjBy4j87FgMCOA5GZfVBTrIDr6kNzHMsGSf/n/aZsQ6rSe+2+zRLpzqwwYJYqEP Dttr5Uemf1L4MEQaErtIChnWhA+wCW5rzTQl8yYGccT5uRZTmg6h20Hhl2FtDwGXsCIF Q8IKKnUTZ24D+uBoadHVACetzDCU3mlwHHxPbrdB1zNqepsORKeOf2PselGvd6WJoLmc gE6UEbJPgyrj1AIEniFzgcujWyv6D1YVvXpdaNTf3l59olfOoGotVOkZ+0fl/yPcOKpw FwmEDFeufma6fLjU8oX+cmw+uYoK1bKaTBLPnL8J+LGlXzNcx2wWDl23qrOtqDvwX887 3zKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Hhvb+RWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lf22si2217973ejb.20.2020.10.07.13.02.16; Wed, 07 Oct 2020 13:02:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Hhvb+RWQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728299AbgJGT0L (ORCPT + 99 others); Wed, 7 Oct 2020 15:26:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:58166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726671AbgJGT0L (ORCPT ); Wed, 7 Oct 2020 15:26:11 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FA492076C; Wed, 7 Oct 2020 19:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602098770; bh=ARBy9A0ue5dqKp5InVcHb1ElW6qKfvo+jYevu8+wq/U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hhvb+RWQ6CdkbJ5w0RajeI+9jps9z2eLNp+IAp5cf1HZtUwQU3SltMtME1qVb3cls 2mTPXr1+dGxa3833DrxJmXcqY6UtvMTxRygGp1olweQPVQBiMfN26qaJpn96SFe78k sWPAONQenDab5v9q+zGC5kVoxOA5GPnXxwkoIYQ8= Date: Wed, 7 Oct 2020 21:26:55 +0200 From: Greg KH To: Haitao Huang Cc: Jarkko Sakkinen , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Jethro Beekman , Chunyang Hui , Jordan Hand , Nathaniel McCallum , Seth Moore , Darren Kenny , Sean Christopherson , Suresh Siddha , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com Subject: Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver Message-ID: <20201007192655.GA104072@kroah.com> References: <20201003045059.665934-1-jarkko.sakkinen@linux.intel.com> <20201003045059.665934-12-jarkko.sakkinen@linux.intel.com> <20201003143925.GB800720@kroah.com> <20201004143246.GA3561@linux.intel.com> <20201005094246.GB151835@kroah.com> <20201005124221.GA191854@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2020 at 01:09:01PM -0500, Haitao Huang wrote: > > > > There is a patch that adds "sgx/provision". > > > > > > What number in this series? > > > > It's 15/24. > > > > Don't know if this is critical. I'd prefer to keep them as is. Directory > seems natural to me and makes sense to add more under the same dir in case > there are more to come. Why is this so special that you need a subdirectory for a single driver with a mere 2 device nodes? Do any other misc drivers have a new subdirectory in /dev/ for them? thanks, greg k-h