Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030626AbWHIJ4O (ORCPT ); Wed, 9 Aug 2006 05:56:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030628AbWHIJ4O (ORCPT ); Wed, 9 Aug 2006 05:56:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:59540 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1030625AbWHIJ4N (ORCPT ); Wed, 9 Aug 2006 05:56:13 -0400 From: Andi Kleen To: Christoph Hellwig Subject: Re: [PATCH 2/3] Kprobes: Define retval helper Date: Wed, 9 Aug 2006 11:55:50 +0200 User-Agent: KMail/1.9.3 Cc: Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, Prasanna S Panchamukhi , Anil S Keshavamurthy , Jim Keniston , linux-arch@vger.kernel.org References: <20060807115537.GA15253@in.ibm.com> <20060809094311.GA20050@in.ibm.com> <20060809094516.GA17993@infradead.org> In-Reply-To: <20060809094516.GA17993@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200608091155.50842.ak@suse.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 417 Lines: 13 > > #define instruction_pointer(regs) ((regs)->eip) > > +#define get_retval(regs) ((regs)->eax) return_value() would match the names of the existing macro better -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/