Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp722495pxu; Wed, 7 Oct 2020 14:15:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwj28f+us0lFMyElsW7aGMWXxo8u+Y+8HWpgqkpiwW+vrpdfm98ZEFQ8Z+lhMuPmTrhJ21t X-Received: by 2002:a50:9ec6:: with SMTP id a64mr5581106edf.382.1602105306460; Wed, 07 Oct 2020 14:15:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602105306; cv=none; d=google.com; s=arc-20160816; b=qe9GaN66kmbYTNgXeNeXmksv+GlbgD8CIKufobRP/IHXzQHPrMxuhSsLY3uYu5+MMx Z0KEEvG81SwrTd7pPzW2J6XH1j117z5e/YLiM9FGBAzLSmEJBFyp7bBJJcGCCpbAzP4d g1ZUB6+FemXVHmae//wbq/XA3hKOCG67BI7eY5oI6Pm5JY0CtHkVGPLYoKZOivRcA720 NoaTR/8r6UCY2L4Bwhs85zcJdfyNM3pjQ/ZO9od6n3B2of/YMfDbnJ+y+6SSTyv1lUOu f87nPm4CMBplVI0hVlQL+76cmOOP6hC0DKSqqvLwfaEHejgLkcFiEBEwWEMLesYVu24k kSZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=SDK3Gt9aT4einF5OjoqPRMgVOrOe8nFuHhFEtB2s2qQ=; b=CLnE3cP5pWCK2AB/QTvqojhAS12n84b0ozLNTy8+xTcNtxOyww903K+XjM5GXxJBVn HsbvnMaOzwU4qPgqlyI4NEBs40eVIdeiLAytFzxiASxR+RsZhacT6u0qgmz/iEGfV8oq 8waTzXqLZJFiyYXDF1MADoMuiKJEAdKXKKoE1oWuO7vbpfrSgP1Y8mwok/jfTeJOcWto R8ZI1tbJIg/VxCwQojASaRRtODBucpSQ4DsHhNBtsFsNlcq+c+YobnoMQbySQD+z+7FQ /hYJNrdcRHI+TJUL7oz9EOjv2UQB6tn5EPrsgPZlUrgobV/93r1eCFuOAcQlMYW6DcSv Px/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TUnMsCVf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si2238152ejd.398.2020.10.07.14.14.43; Wed, 07 Oct 2020 14:15:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=TUnMsCVf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbgJGVMQ (ORCPT + 99 others); Wed, 7 Oct 2020 17:12:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49278 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728227AbgJGVMQ (ORCPT ); Wed, 7 Oct 2020 17:12:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602105134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SDK3Gt9aT4einF5OjoqPRMgVOrOe8nFuHhFEtB2s2qQ=; b=TUnMsCVfe4iM+eFMVc1WikcR5P0Gk69yhUJQkQlXcl3zXoLoPpbD5COpKxfesR+73QWjkI DcNKtR0FvGhwJUIv/NbYTS8mAUvkehLzJ2HQpBFhNqU+vW3/PyIrC9vtlKLXKnVKY1UfVC 8CUhiTKddHaxn8wDFH97CYJfCKA8ieA= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-lQvGFbo4PQmYVIJJIy3BzQ-1; Wed, 07 Oct 2020 17:12:13 -0400 X-MC-Unique: lQvGFbo4PQmYVIJJIy3BzQ-1 Received: by mail-ed1-f69.google.com with SMTP id y8so1440588edj.5 for ; Wed, 07 Oct 2020 14:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SDK3Gt9aT4einF5OjoqPRMgVOrOe8nFuHhFEtB2s2qQ=; b=qS6QVbsmeEy1T3LfqmooyOTqXhEnXaQah6uPjGjUhNxvNl6ICilatW01ZN4v+o1XCp Pqb+PjtKXp1IwC66bMpyVwLagJyRse4NTR+p44UTUc1KXLoFr0mTjhvmRckPgv+oWBf2 atYur2rHMbT87vxz4MaNgJLkTDaUijQMR4S+GBOh/DG7sDDP7m/6yHFAoaNzJ2Iwm7Ah wYtvIkLffc1JioR+w4TG5rYr3Wdwx9xAStuDy32uzLlfeCWnfZnqlPjJVDdXDNMRD5Og RLjTanjZdBQmxaGA4/mMnTFtdnsLqi2S+4lNctFHXqnt6sylFsyQ8PvpYRgLJalT8NmR EXUw== X-Gm-Message-State: AOAM530w0PO0kBEJN4gwYhZkwnbCCs6HwXf6DLZCwi/fC3sZ5qE8zLTD tdMkmdYL1slyVlPQPW+k1rP15IGzYKNxFOp1AwbiXhvb75zmy8YCfm8YnOYAOvl8J4jSc2a1zT/ zTresg6S6IROfP5QCBJHHhtih X-Received: by 2002:aa7:c90a:: with SMTP id b10mr5800430edt.163.1602105131359; Wed, 07 Oct 2020 14:12:11 -0700 (PDT) X-Received: by 2002:aa7:c90a:: with SMTP id b10mr5800409edt.163.1602105131083; Wed, 07 Oct 2020 14:12:11 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id f20sm2232254ejc.90.2020.10.07.14.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Oct 2020 14:12:09 -0700 (PDT) Subject: Re: [PATCH 0/3] Tiger Lake PMC core driver fixes To: "David E. Box" , dvhart@infradead.org, andy@infradead.org, gayatri.kammela@intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20201006224702.12697-1-david.e.box@linux.intel.com> From: Hans de Goede Message-ID: Date: Wed, 7 Oct 2020 23:12:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201006224702.12697-1-david.e.box@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/7/20 12:46 AM, David E. Box wrote: > This patch set adds several critical fixes for intel_pmc_core driver. > > Patch 1: Uses descriptive register names for the TigerLake low power > mode registers. Not critical, but was requested in review of > Patch 2. > > Patch 2: Fixes the register mapping to the correct IPs in the power > gating status register for TigerLake. > > Patch 3: Fixes the slps0 residency multiplier to use the correct, platform > specific values. > > David E. Box (1): > platform/x86: pmc_core: Use descriptive names for LPM registers > > Gayatri Kammela (2): > platform/x86: intel_pmc_core: Fix TigerLake power gating status map > platform/x86: intel_pmc_core: Fix the slp_s0 counter displayed value Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up there once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans