Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: vgarodia=codeaurora.org@mg.codeaurora.org
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 08 Oct 2020 01:33:56 +0530
From:   vgarodia@codeaurora.org
To:     Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc:     linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Alexandre Courbot <acourbot@chromium.org>,
        Mansur Alisha Shaik <mansur@codeaurora.org>
Subject: Re: [PATCH 0/3] Venus dynamic resolution change fixes
In-Reply-To: <20200928164431.21884-1-stanimir.varbanov@linaro.org>
References: <20200928164431.21884-1-stanimir.varbanov@linaro.org>
Message-ID: <cd91071c76f8f2151fdcd70a16c19edf@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Precedence: bulk

Hi Stan,

On 2020-09-28 22:14, Stanimir Varbanov wrote:
> Hi all,
> 
> Those three patches are needed to fix setting of LAST buffer flag 
> during
> dynamic-resolution-change state.
> 
> The first patch in this series fix the LAST buffer flag setting, the 
> second
> unify the driver behavior no matter the event from firmware is 
> sufficient or
> insufficient resources and the third one is moving the locking from 
> buf_queue
> helper function to encoder and decoder buf_queue vb2 ops.
> 
> Comments are welcome!
> 
> Stanimir Varbanov (3):
>   venus: vdec: Fix non reliable setting of LAST flag
>   venus: vdec: Make decoder return LAST flag for sufficient event
>   venus: helpers: Lock outside of buffer queue helper
> 
>  drivers/media/platform/qcom/venus/core.h    |  5 +-
>  drivers/media/platform/qcom/venus/helpers.c | 15 ++--
>  drivers/media/platform/qcom/venus/vdec.c    | 92 +++++++++++++--------
>  drivers/media/platform/qcom/venus/venc.c    | 11 ++-
>  4 files changed, 76 insertions(+), 47 deletions(-)

I have made some comments which are more towards optimizing the reconfig 
event
handling in the driver. I would leave that up to you to either update in 
this series
or take it separately. Either way, i am good with this series.

Reviewed-by: Vikash Garodia <vgarodia@codeaurora.org>