Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp803594pxu; Wed, 7 Oct 2020 16:59:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNMYgi/hXowwpJHBZjY/FGel9V0mCHUS7zgCXH2zxKZC8ClsZhXQOL8aGEE3AHfFXHvUsA X-Received: by 2002:a17:906:ae82:: with SMTP id md2mr5780231ejb.538.1602115153565; Wed, 07 Oct 2020 16:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602115153; cv=none; d=google.com; s=arc-20160816; b=fXE4a7tLDVhcNBo0gUfou0xIpF0mWQebgY8E2kbuKN6bOWOO0kHNfBmZDdvx2NJzh6 u2Dyw2OFpLqgjlMCmFZJq4NssbV7svVOu0YDtarcTNr60kLyZVORMfQwpFk2MlNQZT2v Lx7GglNb+n89oUi0P6SpDlh5ywqhJZLtaRLNTFmTR9iHdQqQ25T26YL5k1i4paL9BKlA WHvQ1S8ZGqhJYG1QWXVvto+Y6PJLARuiCwz4h5N+d0yRhsQIejqMt3Kt0QzM5FuJ7PVf FqA0/fHg3N5EX2+N0dzr74b7RasPKOUH9j99itpqJ2zSAYTMGgBFeK9AkF4HMgv/4SS0 PiIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=Kkxtl734H9ur0+t1A0FnBkYH8B0lcb7nqVbT4HdqD1I=; b=XhWcqsyseGvrL+JcwMic9HgEVKPI0m7WlVoumWwovnu3KUtGkNzmID3otCO6/cUjCv okSj3lxbz6KEZQlAKuGfGZXWER9YTvs1tcfuffUuTchN14ms7OcWrOcDMAU20POh6kow wshfdKDYfK70DjWHr27F40thyrPNr0McVwseMTAaaIe82MEvwiwJBQ6zeSqpByYZkEgm zKfh9h9zDsqjzD/4N6DGm4cXFqNteXyKUHNzRztRXXZnIH9y8o/7CzURKZhMzROFPfUO o+BdgPhEKgXs9IIRhj8Eu8lqJLrcZXdBED/Yj7Qua7c2BmpybfOyiSkfR9L0PsnOVL+J oUew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id di17si2409266edb.84.2020.10.07.16.58.50; Wed, 07 Oct 2020 16:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728216AbgJGWsB (ORCPT + 99 others); Wed, 7 Oct 2020 18:48:01 -0400 Received: from smtprelay0033.hostedemail.com ([216.40.44.33]:34322 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727353AbgJGWsB (ORCPT ); Wed, 7 Oct 2020 18:48:01 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 8ECAF18029120; Wed, 7 Oct 2020 22:48:00 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3867:3870:3871:4250:4321:5007:6119:10004:10400:10848:11026:11232:11473:11639:11658:11914:12043:12297:12438:12555:12740:12760:12895:12986:13069:13160:13229:13311:13357:13439:14096:14097:14659:14721:21080:21220:21611:21627:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: home58_190c87d271d3 X-Filterd-Recvd-Size: 2187 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Wed, 7 Oct 2020 22:47:58 +0000 (UTC) Message-ID: Subject: Re: [PATCH] drm/fourcc: Add AXBXGXRX106106106106 format From: Joe Perches To: Matteo Franchin , dri-devel@lists.freedesktop.org Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch, brian.starkey@arm.com, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, nd@arm.com Date: Wed, 07 Oct 2020 15:47:57 -0700 In-Reply-To: <20201007092725.13300-1-matteo.franchin@arm.com> References: <20201007092725.13300-1-matteo.franchin@arm.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-10-07 at 10:27 +0100, Matteo Franchin wrote: > Add ABGR format with 10-bit components packed in 64-bit per pixel. > This format can be used to handle > VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 on little-endian > architectures. trivial note: > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c [] > @@ -202,6 +202,7 @@ const struct drm_format_info *__drm_format_info(u32 format) > { .format = DRM_FORMAT_XBGR16161616F, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1 }, > { .format = DRM_FORMAT_ARGB16161616F, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, > { .format = DRM_FORMAT_ABGR16161616F, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, > + { .format = DRM_FORMAT_AXBXGXRX106106106106, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true }, My is to separate this into 2 lines so every column including .depth on still visually aligns. + { .format = DRM_FORMAT_AXBXGXRX106106106106, + .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },