Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp805949pxu; Wed, 7 Oct 2020 17:03:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyorsMC8jtk69WemDU/L2P8dJGxT4QarG5oR/P5anoEs2+3mrtOuIbpbSGYT6CnhiEri+AZ X-Received: by 2002:aa7:dd49:: with SMTP id o9mr6417254edw.331.1602115382144; Wed, 07 Oct 2020 17:03:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602115382; cv=none; d=google.com; s=arc-20160816; b=o8sy9yBTViJdAUkEGZwEgJcDc2l9k/gQX4axe2jicmtKFJXI7I+W1w548pgMkQnQJ0 ru794P/QzizNpZXXYLniqSlxb0eT2IcDF8NAHPmrRb3ppJsu+7DEsb++E6Cz29bIhJpM 5HNT412FHDcaV557aXV/0Vd/d9zbC5j8TJnr9hFRvkM4pdz0cRtosnu2ECT4hmv56siR bGbkdSjqrBdV6MLEtl5d/plVkBc4SW9MBTKQEg2EzSuX69eOU5I42U6P8NvRsDY6T1jg cFO5XIoM2X9LWcFy+y2mFoJ1I2M9oVmOpEiyBKwQgzDFDXjeld+bu7XRHhjgSyzVqPAy k1yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=KlqdeBOeduNZHbvz8a9dx4Zi0tpBzHtGOZfwTJaFVzU=; b=cK8vn/2xdQLv2lcmcJSXKZkU5JmG05nXRkFH9Q1DIYGhAmOZageWr/mkGrp+1TIMPR YRWkhUyJzVslNvPNw9Hg9TcAUfM9vglhNio08Pkl9ufh0sRMPE1ei+LZ2R9NPmUgXXtg buQSGtG/T+YtJRWau/NtQ7KvTdPgRvMujE4nM0katIoEN+JsZg9o5K4bUtSd08vuYi1H vc/jM7J+B7xigO2HsGmqLGVLm3MC+WH1oWGAP6wsn+qK+kwFFLWYLolSaGfG4JO3BFk6 pVC0TIat2oNYQCbMYeLy7G/Czl6A3iAyT0fk1/DQGEyiGwdQgp/P0zEjZp763zjONekJ x1xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="b9ntPm/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x88si2694655ede.291.2020.10.07.17.02.39; Wed, 07 Oct 2020 17:03:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="b9ntPm/Q"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728475AbgJGXRM (ORCPT + 99 others); Wed, 7 Oct 2020 19:17:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:33132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728008AbgJGXRL (ORCPT ); Wed, 7 Oct 2020 19:17:11 -0400 Received: from paulmck-ThinkPad-P72.home (50-39-104-11.bvtn.or.frontiernet.net [50.39.104.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9915F2083B; Wed, 7 Oct 2020 23:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602112630; bh=hg6aP17vVeT5HtNbBZRGYFHcTvAc9urL7A0N3k6Rs/Y=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=b9ntPm/Q19HqRTTxmu0levBFRn8w9N+DDPuIcfnatpwY1f3tfUsXk3rVwJS4MW43s PIWHvJqSfDEGUlzbyiav4UQqKswyNAyNmbpxpWPCqX4SAtJs2vChVQOrZVuh2l60xJ xxmMDED3fME3XvUDbqmQn3VdXl1Vma2v7oJGSVdM= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 3B3B93522FA4; Wed, 7 Oct 2020 16:17:10 -0700 (PDT) Date: Wed, 7 Oct 2020 16:17:10 -0700 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, neeraju@codeaurora.org, Josh Triplett , Lai Jiangshan , Mathieu Desnoyers , rcu@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH v2] rcu/tree: nocb: Avoid raising softirq when there are ready to execute CBs Message-ID: <20201007231710.GW29330@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20201005021132.146534-1-joel@joelfernandes.org> <20201007223438.GU29330@paulmck-ThinkPad-P72> <20201007231346.GA58749@lothringen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201007231346.GA58749@lothringen> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 01:13:46AM +0200, Frederic Weisbecker wrote: > On Wed, Oct 07, 2020 at 03:34:38PM -0700, Paul E. McKenney wrote: > > On Sun, Oct 04, 2020 at 10:11:32PM -0400, Joel Fernandes (Google) wrote: > > > During testing, I see it is possible that rcu_pending() returns 1 when > > > offloaded callbacks are ready to execute thus raising the RCU softirq. > > > > > > However, softirq does not execute offloaded callbacks. They are executed in a > > > kthread which is awakened independent of the softirq. > > > > > > This commit therefore avoids raising the softirq in the first place. That's > > > probably a good thing considering that the purpose of callback offloading is to > > > reduce softirq activity. > > > > > > Passed 30 minute tests of TREE01 through TREE09 each. > > > > > > On TREE08, I notice that there is atmost 150us from when the softirq was > > > NOT raised when ready cbs were present, to when the ready callbacks were > > > invoked by the rcuop thread. This also further confirms that there is no > > > need to raise the softirq for ready cbs in the first place. > > > > > > Cc: neeraju@codeaurora.org > > > Signed-off-by: Joel Fernandes (Google) > > > > Looks good, applied, thank you! I reworked things a bit based on > > previous patches and to more precisely capture why this patch does > > not cause additional problems. Please let me know if I messed > > anything up. > > > > Thanx, Paul > > > > ------------------------------------------------------------------------ > > > > commit 33847a34a2d261354a79b4a24d9d37222e8ec888 > > Author: Joel Fernandes (Google) > > Date: Wed Oct 7 13:50:36 2020 -0700 > > > > rcu/tree: nocb: Avoid raising softirq for offloaded ready-to-execute CBs > > > > Testing showed that rcu_pending() can return 1 when offloaded callbacks > > are ready to execute. This invokes RCU core processing, for example, > > by raising RCU_SOFTIRQ, eventually resulting in a call to rcu_core(). > > However, rcu_core() explicitly avoids in any way manipulating offloaded > > callbacks, which are instead handled by the rcuog and rcuoc kthreads, > > which work independently of rcu_core(). > > > > One exception to this independence is that rcu_core() invokes > > do_nocb_deferred_wakeup(), however, rcu_pending() also checks > > rcu_nocb_need_deferred_wakeup() in order to correctly handle this case, > > invoking rcu_core() when needed. > > > > This commit therefore avoids needlessly invoking RCU core processing > > by checking rcu_segcblist_ready_cbs() only on non-offloaded CPUs. > > This reduces overhead, for example, by reducing softirq activity. > > > > This change passed 30 minute tests of TREE01 through TREE09 each. > > > > On TREE08, there is at most 150us from the time that rcu_pending() chose > > not to invoke RCU core processing to the time when the ready callbacks > > were invoked by the rcuoc kthread. This provides further evidence that > > there is no need to invoke rcu_core() for offloaded callbacks that are > > ready to invoke. > > > > Cc: Neeraj Upadhyay > > Signed-off-by: Joel Fernandes (Google) > > Signed-off-by: Paul E. McKenney > > Reviewed-by: Frederic Weisbecker Applied, and thank you very much! Thanx, Paul