Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201004032536.1229030-1-krisman@collabora.com> <20201004032536.1229030-7-krisman@collabora.com>
In-Reply-To: <20201004032536.1229030-7-krisman@collabora.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Wed, 7 Oct 2020 17:05:51 -0700
Message-ID: <CALCETrW5Oq0L0G7JrjYLFp08+y4kr0STkmn8cf4LKcHOfz0heQ@mail.gmail.com>
Subject: Re: [PATCH v3 06/10] x86: elf: Use e_machine to select start_thread
 for x32
To:     Gabriel Krisman Bertazi <krisman@collabora.com>
Cc:     Andrew Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Christoph Hellwig <hch@lst.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
        Robert Richter <rric@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Christopherson, Sean J" <sean.j.christopherson@intel.com>,
        kernel@collabora.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Oct 3, 2020 at 8:26 PM Gabriel Krisman Bertazi
<krisman@collabora.com> wrote:
>
> Since TIF_X32 is going away, avoid using it to find the ELF type in
> compat_start_thread.
>
> According to SysV AMD64 ABI Draft, an AMD64 ELF object using ILP32 must
> have ELFCLASS32 with (E_MACHINE == EM_X86_64), so use that ELF field to
> differentiate a x32 object from a IA32 object when executing
> start_thread in compat mode.

Hmm, I suppose I can live with this.  It's not fundamentally worse
than any of the other ELF compat hacks.

Reviewed-by: Andy Lutomirski <luto@kernel.org>