Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp866701pxu; Wed, 7 Oct 2020 19:16:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZ8vKLii0KONLW5RQYrVktudfHNd5QCG53nBh++o5KXFXqT+e/+sQE1xlMDRyLKvJEghAW X-Received: by 2002:a17:906:170e:: with SMTP id c14mr6284319eje.275.1602123380211; Wed, 07 Oct 2020 19:16:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602123380; cv=none; d=google.com; s=arc-20160816; b=zOjcivG/mmEA46wElpYfVsv7Cdr6IxG0gwGok4sRRBPVlSZEu3d6FcfzuyO99jS1tX b0tMhY6bbyTZ8sDcrpX9zbyfEG9n8pNZoxl9RmR3ixDN42qXlS7vPMcY8uTbqS0WFUd8 D3ISK/xl/jVvv6N2OXXHskW7xgsMJjiK/woOUIRyOuNe81yTGzbyiXYfluhyiHus6Jb/ AKPbKVYuiAcFucwcYQOJUETX6L/Hpa/3Zxq7KymcyNNGl01h+JxX7mi6De8xrclC11mQ d9wpWT97q8jVpq6sshujfWaElLUIuii1fNHX7AnnlzgQjb4JBRjI+Y2xMggdm4rFxFAG myyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=fKGpwbpCUrO7poR5kPR53uD17H/Na+4QP1jfSojSiHY=; b=wXHeaEeQDoYUyTh/SEi+tzImtAMu7z/JqgBheRpT572W4VNOji1qhO/F/192UN3QTm idH9ME7DkrsFLZvcAqbqz2dQipFN9jFJ/FVtDsSUnoQvR5/vNvCXs7DHP7yyJ+Gc+woV /Soh9div5Glmp/WIjCDv2vuV8C6Hb7IpW+SAte2ICWkD3y1KGZbAwFnQZv6v3SfbUj2d fOFgQSYW7YdTcCYYeyR4pYUEVluzAFHgWl5tiS4tp89HjyeWhnC37Z0GNnLnlXtIQmpS y0n4zOMFGoK7aLf/PQGPoFBefkXglm9rZFclokdLm4ndR35irTJ9CzGUITuQT0u0xPNz Ym/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=RJXCBbRU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si785203ejc.568.2020.10.07.19.15.57; Wed, 07 Oct 2020 19:16:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=RJXCBbRU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728193AbgJHCNQ (ORCPT + 99 others); Wed, 7 Oct 2020 22:13:16 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:53386 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727742AbgJHCNQ (ORCPT ); Wed, 7 Oct 2020 22:13:16 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09823U7Q174732; Thu, 8 Oct 2020 02:13:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=fKGpwbpCUrO7poR5kPR53uD17H/Na+4QP1jfSojSiHY=; b=RJXCBbRUshXl3o4xApOq0CU1fcZDBdKuTRc4Lcc9SePdZmrKEnBmYKNHFfmldeI6ePAy 1CqSF4d+EYHKab5AUWm53vH+bJkJ+pwai3Oj94DmfKJaslg7V9kPQh5sJvgCB6PJeu8C ZZdafPkLIw7KN2SHC1g569PPJUQO+v6jBN+gR/h2IU2kSdT3JTYwXmDA2zEY+um9qIaX 2kgouNRwg2uAWXNpVHhEo0dIA8T2nTfdAP5kpYNbGO3ZjO0/rTMJlt/gn7JE59HHiAKY FFeyMG6TPRIPOcVyhLVzYJRBLNl7lR9estHrIVbk41C/Gzhv0n+LcxrKA5wPsB3mPpIi BQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 33xhxn52bs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 08 Oct 2020 02:13:02 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09824rgA114571; Thu, 8 Oct 2020 02:13:01 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 3410k0cpcw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Oct 2020 02:13:01 +0000 Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0982Cx4r031199; Thu, 8 Oct 2020 02:13:00 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 07 Oct 2020 19:12:59 -0700 To: Pavel Machek Cc: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qla2xxx: Use constant when it is known. From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20200921112340.GA19336@duo.ucw.cz> Date: Wed, 07 Oct 2020 22:12:57 -0400 In-Reply-To: <20200921112340.GA19336@duo.ucw.cz> (Pavel Machek's message of "Mon, 21 Sep 2020 13:23:40 +0200") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9767 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=954 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=1 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010080017 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9767 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=1 phishscore=0 mlxlogscore=968 adultscore=0 clxscore=1011 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010080017 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pavel, > Directly return constant when it is known, to make code easier to > understand. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering