Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1602125965-31698-1-git-send-email-zhouzhouyi@gmail.com> <1e7d9b9a-b90b-48c5-1fd9-51244b843507@infradead.org>
In-Reply-To: <1e7d9b9a-b90b-48c5-1fd9-51244b843507@infradead.org>
From:   Zhouyi Zhou <zhouzhouyi@gmail.com>
Date:   Thu, 8 Oct 2020 11:08:44 +0800
Message-ID: <CAABZP2xysbJGq=8iccoie2EauTo4TWdu7Ay3tKjTq74N715bqQ@mail.gmail.com>
Subject: Re: [PATCH] kprobes: Correct a type error in function kprobes_module_callback
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     naveen.n.rao@linux.ibm.com, anil.s.keshavamurthy@intel.com,
        David Miller <davem@davemloft.net>, mhiramat@kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks for the tip!

On Thu, Oct 8, 2020 at 11:06 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> On 10/7/20 7:59 PM, Zhouyi Zhou wrote:
> > There is a tiny type error in comment of function kprobes_module_callback.
>
> Preferable
>                   typo
> and same in $Subject.
>
> 'type' usually means data type or maybe typedef, or even
> font or typeface.
>
> I suppose you could say a "typing" error (as in using a typewriter
> or keyboard).
>
> >
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> > ---
> >  kernel/kprobes.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index e995541..9d2042b 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -2432,7 +2432,7 @@ static int kprobes_module_callback(struct notifier_block *nb,
> >                            within_module_core((unsigned long)p->addr, mod))) {
> >                               /*
> >                                * The vaddr this probe is installed will soon
> > -                              * be vfreed buy not synced to disk. Hence,
> > +                              * be vfreed but not synced to disk. Hence,
> >                                * disarming the breakpoint isn't needed.
> >                                *
> >                                * Note, this will also move any optimized probes
> >
>
> thanks.
> --
> ~Randy
>