Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: =?UTF-8?B?UmU6IFtQQVRDSCAyLzJdIHVzYjogY2RuczM6IFZhcmlhYmxlIOKAmGxl?=
 =?UTF-8?Q?ngth=e2=80=99_set_but_not_used?=
To:     Pawel Laszczak <pawell@cadence.com>,
        Sergei Shtylyov <sergei.shtylyov@gmail.com>,
        "balbi@kernel.org" <balbi@kernel.org>
CC:     "peter.chen@nxp.com" <peter.chen@nxp.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>
References: <20201007033932.23050-1-pawell@cadence.com>
 <8994106d-2cc5-fa2c-bbcc-6526632ff80b@ti.com>
 <18bf46b7-d86a-fbf0-9ce7-c2d0765758f1@gmail.com>
 <DM6PR07MB552984371C356A6E31D8D116DD0B0@DM6PR07MB5529.namprd07.prod.outlook.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <d88c92c7-acc6-df22-09e2-f5ddfba1d76b@ti.com>
Date:   Thu, 8 Oct 2020 10:29:40 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <DM6PR07MB552984371C356A6E31D8D116DD0B0@DM6PR07MB5529.namprd07.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Pawel,

On 08/10/2020 06:57, Pawel Laszczak wrote:
> Siergei,
> 
>>
>> On 10/7/20 11:15 AM, Roger Quadros wrote:
>>
>> [...]
>>>> Patch removes not used variable 'length' from
>>>> cdns3_wa2_descmiss_copy_data function.
>>>>
>>>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>>>
>>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>>
>>    No "commit" is needed here.
> 
> Can you explain why?
> 
> I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version,
> or because it's only warning - not error.
> 
> Am I right ?

Siergei meant that the word "commit" should not be used. So it should be

Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")

cheers,
-roger

> 
>>
>>> Acked-by: Roger Quadros <rogerq@ti.com>
>> [...]
>>
> 
> Regards,
> Pawel
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki