Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1074224pxu; Thu, 8 Oct 2020 02:36:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4607pHdw9kchOu6gX9c8g2iwsZBCBlstTPeq/QC+qSA+QjfJ00wZK+c4vO4DlOxW44Eg4 X-Received: by 2002:a17:906:9483:: with SMTP id t3mr8028386ejx.390.1602149780313; Thu, 08 Oct 2020 02:36:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602149780; cv=none; d=google.com; s=arc-20160816; b=HuYoOuLJXADiAgsYQybbnF4VonvGI2HwxiYSlVaq8Gf9+03jJSexDnJAWmvVpAXP/X BxRQqTSVxt90ovtKuetRMoak7s1hPIwBjCLdNDkDZ0vXxvHPc5SgjAMdKzKMi+qlUSSj +WMfUE15ptvjwElqnQDTm71671pa6HJjQW0631abgmyT+G9q774yDEsYbIWLgb6+5kAr gT9LQSZXcxex/Xbte6EiBiSUEYjh9BVVyoZix7z39FF7i4dpaSQvk6ImcfiP6H4qzfCL KboDuI7BM3UvWGGnc8XzpJJhmSDqYBEEVHYKviKZFTk8QSyREwjZKq/0tAVsl97O9N+t N/Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Ky6B9tzxN97erkw+L3nihgRW4OC9vjJOPwyhfBdbivM=; b=CWbbZGAYMjpqZGUTvrn8qCCgNkFDQtdpP4jSryOyY7r+jepV7k/zlNY3y6Y/K5MkC3 hj4UQyfSmeMV7ZRWUVXDQVhdVMAwB4BeRC3CPLGkjJ0Mc0HqHc6DAopxTMxsN2Yll59m lKrgiEeii8jg6PzItO9v3lNHzq0NB8AsxSQi8N0T/j7Nh4beNCfs7cEXjAGHuWd6tbcJ 9ETY2grEnUuWQ8njZGF4cJZQPlOfdnPOlK9/x4jwV4eHoMSVEeX8nX0rhuZIWr6guLCf XKLK+bjfR2GGyQHELquI4CB6SzCRDo7uOf9Kgv4ka2yhnZEFv3QDu53ydSXsSr8XyfAg XFHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hJ6kgqwb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u18si3449831edy.380.2020.10.08.02.35.57; Thu, 08 Oct 2020 02:36:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hJ6kgqwb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725882AbgJHJeX (ORCPT + 99 others); Thu, 8 Oct 2020 05:34:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbgJHJeW (ORCPT ); Thu, 8 Oct 2020 05:34:22 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6ACDC061755 for ; Thu, 8 Oct 2020 02:34:22 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id a200so3504616pfa.10 for ; Thu, 08 Oct 2020 02:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ky6B9tzxN97erkw+L3nihgRW4OC9vjJOPwyhfBdbivM=; b=hJ6kgqwbkmiF+RvoAlO+KDFQRiWTJWGEZCGcib6sEFkrkP/9ioxTPU/3+Ump8jnpMH R+54SWbf0ge46G0SySQ5qFrvzhoUXIgnEixyPrhOrCyIuZWPOtMtsxEcf2r6sijAtoS6 6Ope6x8XjIt+Unfrf/47HdTxoQjqg+KP8fgA8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ky6B9tzxN97erkw+L3nihgRW4OC9vjJOPwyhfBdbivM=; b=SgBkfVwmSKgG08iL2ATiM0LC2zEK7MhjddlPNE2t9JOhkCEcynnOZ5BaLVdDNBDQtw MZMJogju0YaohPT5f0zMoYnpMlv2Co7+Dt6Xm0nX9s0KqCQiSxH0fD2ayBleuWdub15I A1WgdYzgwREb5Us1jL5cqYysb333sUhY8wjX06HJvPHsNJi0E7UokHR/AV6sBDg4/P1p R+AVvWvyXXdtli90XImzMyQFRRRJff8xOZNE4b6lG65wwnmjx7LFgF0kKzSuPKktT52I dyqLtWJOh7Ikt5UrGpQrgjtIDHJZ4TlWh0k7zNZ2HKroFbhI8tV8b3aP7mKD+nwpNrBO wefA== X-Gm-Message-State: AOAM530my9AXNbu/TkGNXV3nCmgVqDL6SasFryMihgQwCYj2KuXV/j2R 0elEFnWDLJeZC4gS5RQ9ty9yZw== X-Received: by 2002:a62:5382:0:b029:155:6333:ce4f with SMTP id h124-20020a6253820000b02901556333ce4fmr1061372pfb.28.1602149662342; Thu, 08 Oct 2020 02:34:22 -0700 (PDT) Received: from fshao-glinux.tpe.corp.google.com ([2401:fa00:1:b:1a60:24ff:fe90:ea5a]) by smtp.gmail.com with ESMTPSA id q7sm6113711pfj.38.2020.10.08.02.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 02:34:21 -0700 (PDT) From: Fei Shao To: Eddie Huang Cc: Fei Shao , linux-rtc@vger.kernel.org, Hsin-Hsiung Wang , Alessandro Zummo , Lee Jones , Sean Wang , linux-kernel@vger.kernel.org, Josef Friedl , Ran Bi , linux-mediatek@lists.infradead.org, Alexandre Belloni , Matthias Brugger , linux-arm-kernel@lists.infradead.org Subject: [PATCH] rtc: mt6397: Remove unused member dev Date: Thu, 8 Oct 2020 17:34:14 +0800 Message-Id: <20201008093414.1911699-1-fshao@chromium.org> X-Mailer: git-send-email 2.28.0.806.g8561365e88-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Removing the struct member "dev" in mt6397 RTC driver because it's not initialized and the only usage is for one debugging message. Also fixed a typo in the error message. Signed-off-by: Fei Shao --- drivers/rtc/rtc-mt6397.c | 3 ++- include/linux/mfd/mt6397/rtc.h | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index f8b1353777ba..1894aded4c85 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -31,7 +31,8 @@ static int mtk_rtc_write_trigger(struct mt6397_rtc *rtc) MTK_RTC_POLL_DELAY_US, MTK_RTC_POLL_TIMEOUT); if (ret < 0) - dev_err(rtc->dev, "failed to write WRTGE: %d\n", ret); + dev_err(rtc->rtc_dev->dev.parent, + "failed to write WRTGR: %d\n", ret); return ret; } diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h index 66989a16221a..c3748b53bf7d 100644 --- a/include/linux/mfd/mt6397/rtc.h +++ b/include/linux/mfd/mt6397/rtc.h @@ -72,7 +72,6 @@ struct mtk_rtc_data { }; struct mt6397_rtc { - struct device *dev; struct rtc_device *rtc_dev; /* Protect register access from multiple tasks */ -- 2.28.0.806.g8561365e88-goog