Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1121818pxu;
        Thu, 8 Oct 2020 04:03:27 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwncLJjMml6DBTiUqylhbBIw66jq7kvEnTEtKjpiB7LdCFsQ4VntyBZcz227BkGGxuGyV5x
X-Received: by 2002:a05:6402:395:: with SMTP id o21mr8267716edv.2.1602155006955;
        Thu, 08 Oct 2020 04:03:26 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1602155006; cv=none;
        d=google.com; s=arc-20160816;
        b=P6RpALFkULOaDfK6cyhaj828ypGTqxsqpkNzPw+BH6IMblF60zwXn3oghDG6NqB2ZK
         b7WrGHjsdTnhbGrvfbNuuacYjvQH9AI3cxp8AnAyuHXvD6FswqezCSJrNSxinBEQKfWu
         Sh+lr6IHlt5k/sLcRhA0Y6Dj4NGh3NmIntc4DpR6GSW5GUvOp6uN5XESBTI2M0svnmST
         RckJQ/9+b3soltmbvqudfNCGRAt49hRdWZNX5oYj16BE+1pbB8uD0BxR+I5sZ8gSIExi
         kIEF2t+bo3HdjIgvDYyEJBCsxx8GGUdnirErYgBzx2+MUzbqY8JRR1icNIJ5D8zmqdKO
         uHmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=6beFj2UnhDCX3evJi2LywZoGkp9gliipgFfCKDdVez4=;
        b=l6ryksC6oSW9pbO9MBRt7OZBr2CQ7sPoB6JByDIRi+oqOevpWhL9ZKVvjepi43emF7
         u/PORGbW6O5BfvO/jn8+Vwy6SMugaAo+TIkkovviRCQcJyam/QXRPYv52H+Mkw0/+G2i
         bG6pYd/tT5hv1e1nHyrUmaKp41LOVpyRbFKKf6+90btFy56w9Qrt+/+c/exrw6UBHamx
         mADYmfnq96ZHM5JHVi2cIoZcVGN3AG9laKcR3HVV3bJYgkCpUNAIn10oTuwfeA98ZuqC
         bDMOcOo4GRVdXtSDfKLp6mHy/8R2xVx8oAGJZmvRjfIcbw+fd0166Y9tshvhH2hPjjIm
         40jw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=qLDyB9wv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id m21si3440606ejq.199.2020.10.08.04.03.03;
        Thu, 08 Oct 2020 04:03:26 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=qLDyB9wv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729105AbgJHJax (ORCPT <rfc822;zhangckid@gmail.com> + 99 others);
        Thu, 8 Oct 2020 05:30:53 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38844 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725849AbgJHJaw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Oct 2020 05:30:52 -0400
Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7EBCC061755
        for <linux-kernel@vger.kernel.org>; Thu,  8 Oct 2020 02:30:52 -0700 (PDT)
Received: from zn.tnic (p200300ec2f0a90008b2588e9c28ae899.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9000:8b25:88e9:c28a:e899])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A54C91EC0409;
        Thu,  8 Oct 2020 11:30:50 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
        t=1602149450;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
        bh=6beFj2UnhDCX3evJi2LywZoGkp9gliipgFfCKDdVez4=;
        b=qLDyB9wvmGT0gyBeU2w/UiqmPt6wQjIsBFnQKsdXzj99xm/D+exLuANB9HKyUZJQin/GbP
        2WFm0cG9Cg3CKSDVMh3E47qFbiCPDzpo08107MlOVYx6Vw5ty+7ODiU99rBOxBxyfK6fwd
        i9ACg4we0xbIVCQe4E2VM7I/J8G7YNw=
Date:   Thu, 8 Oct 2020 11:30:42 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Arvind Sankar <nivedita@alum.mit.edu>
Cc:     x86@kernel.org, Joerg Roedel <jroedel@suse.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] x86/boot: Move get_cmd_line_ptr() and
 COMMAND_LINE_SIZE into misc.h
Message-ID: <20201008093042.GA6491@zn.tnic>
References: <20201007195351.776555-1-nivedita@alum.mit.edu>
 <20201007195351.776555-3-nivedita@alum.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201007195351.776555-3-nivedita@alum.mit.edu>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 07, 2020 at 03:53:48PM -0400, Arvind Sankar wrote:
> Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h for easier
> use from multiple files.

Well, I don't like that. cmdline.c *is* for cmdline-related things.
misc.h is a dumping ground for everything but the kitchen sink.

Why can't you leave it there and make it visible to other compilation
units?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette