Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1153238pxu; Thu, 8 Oct 2020 04:53:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrM//rblktj2h94pCMBwWnyoYSia2k6HLAoNTIuhvzAAfwff+xxZ36cBpw7OAgBIZUB9h1 X-Received: by 2002:aa7:df0c:: with SMTP id c12mr8618050edy.20.1602158028888; Thu, 08 Oct 2020 04:53:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602158028; cv=none; d=google.com; s=arc-20160816; b=li+9iM+xb8vvcBBJu8Z6ZOVtD2I9U6BmG76wTdOrqnNhiggwcMbF4UHuvucMA6oPJh MLYE7ZnIP16Bh1FvI9uxh5NpaNWl3q3ihQhrXGFK28mj2T9tJpIyJU8QOr45e1RawKLF 12GnmhYzI42oWsk77cU37Aoc1WMYIf1VLuGQloV9khA+wqbopFOIRHK2aNGtHVnxieFY RThHyeiFTOXfTjlSTMsO4JMbU4lXsaiaffHlOXoyTPa8HnkhrUNHa8CR6MnN5iu6Ddug qBI28JRwk9k1rfOjgmUDUc64ib7YkcMqE2+5vPBbwKWd4vha68FHK03ECuaSjMM/8qVA HWng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Q0HJGNFe6NzrklcyPAabu1eCVbokIfLVWE/hrhyeP7E=; b=0EuihUTp6Is4uKLKcqMrqsDpqvKNNZ0aUbm1gMHV9+Co4WJUCWexBbx5rw2q8hdc7V uaYPUVaw8SGfeMpspADLBPSA1gQc5OjgQXolACDrNMhuntx2ftNTyWLytYpWoFVhZ6rl KSix8D0r+OE+O+Q61HgIfZDwoxanBk9oEZy56tESSQjIzeFEmEWYxRoBntG+yYLTSTyJ +RsVC9gaCQe559XZTomlxNwZYftGV2r4IjhXVJ0s2EYpZuozitV+w9PxapYDX9dTRrYC NVyWLB+8Jrb30/DDYweyTsnslF6EnhqIO59PkhDhtjI68gMj2RdkPdTMXgVNpWFbSiEB DhZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w15si1305546edr.434.2020.10.08.04.53.25; Thu, 08 Oct 2020 04:53:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729838AbgJHLgZ (ORCPT + 99 others); Thu, 8 Oct 2020 07:36:25 -0400 Received: from foss.arm.com ([217.140.110.172]:52390 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725917AbgJHLgW (ORCPT ); Thu, 8 Oct 2020 07:36:22 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1982D6E; Thu, 8 Oct 2020 04:36:21 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 911463F71F; Thu, 8 Oct 2020 04:36:20 -0700 (PDT) Date: Thu, 8 Oct 2020 12:36:14 +0100 From: Lorenzo Pieralisi To: Jisheng Zhang Cc: Kishon Vijay Abraham I , Rob Herring , Bjorn Helgaas , Jingoo Han , Gustavo Pimentel , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 0/2] PCI: dwc: fix two MSI issues Message-ID: <20201008113614.GA1226@e121166-lin.cambridge.arm.com> References: <20200930091205.792d6c7c@xhacker.debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930091205.792d6c7c@xhacker.debian> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 09:12:05AM +0800, Jisheng Zhang wrote: > Fix two MSI issues. One to skip PCIE_MSI_INTR0* programming if MSI is > disabled, another to use an address in the driver data for MSI address, > to fix the MSI page leakage during suspend/resume. > > Since v4: > - fix pci-dra7xx.c > > Since v3: > - add Acked-by tag > - change patch2 commit msg to make it clear > - map the MSI msg with dma_map_single_attrs() for some platforms > which either has seperate addrs for dma and phy or has mem access > limitation for the PCIe. > > Since v2: > - add Acked-by tag > - use an address in the driver data for MSI address. Thank Ard and Rob > for pointing out this correct direction. > - Since the MSI page has gone, the leak issue doesn't exist anymore, > remove unnecessary patches. > - Remove dw_pcie_free_msi rename and the last patch. They could be > targeted to next. So will send out patches in a separate series. > > Since v1: > - add proper error handling patches. > - solve the msi page leakage by moving dw_pcie_msi_init() from each > users to designware host > > > Jisheng Zhang (2): > PCI: dwc: Skip PCIE_MSI_INTR0* programming if MSI is disabled > PCI: dwc: Fix MSI page leakage in suspend/resume > > drivers/pci/controller/dwc/pci-dra7xx.c | 18 +++++++++- > .../pci/controller/dwc/pcie-designware-host.c | 34 +++++++++---------- > drivers/pci/controller/dwc/pcie-designware.h | 2 +- > 3 files changed, 35 insertions(+), 19 deletions(-) Hi, can you rebase this series against my pci/dwc branch please ? Thanks, Lorenzo