Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1224146pxu; Thu, 8 Oct 2020 06:30:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGCvSshAMxYiSt8/kO2e112mqpEGs5UxUpYroitZhNrcpJO8VboMN/GnA5mbigJXopR/y3 X-Received: by 2002:a50:bb0c:: with SMTP id y12mr9143452ede.355.1602163825367; Thu, 08 Oct 2020 06:30:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602163825; cv=none; d=google.com; s=arc-20160816; b=acjbacw+uxf9EaxQxmMtAZWTPM25j7lV3tsbjhFkx4RqiqGOcQEZ7T99yiGIBpb8x1 1O5oDzxUKTV38Isiqj6iU1p9RtLaXosi+Idb9N9SKukU77vmmASX1p+gkUeLMOUmnqQH 9u+8x0JGZ2dPyQ/RrTQVFAgJaoTi0Dq3WteBnJ/D++81L0By9GHGlTnS5fC4jD0GF0x8 IxvXgZD/g8CxRk+hCXc6Kdx+E24wu96SI5XANT5XuDwsYJdUl9jUMbLMrLDLPUfF+4v1 LMRXZdCmOLceAErWDzpWNTJ7WYZOgkyy8NNsnskU5Wc8yOaRbaezY2PNOB5h0lh2JbZP c1Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4Udupsb/n1o2VfYDaX1x29f+NgYQ2LOLwGNy4Q7PY2E=; b=VdXsfGB1HLMwkcdBKhPjMxYTiuzMPM0rPqTZDsNRXAEZ3rFstmx5czUbqegSy2IlnU QG6hqXhjK4sgFISHNg6H+BhoklN6iYlzKRPahX2cd76Jud/A/YruiSI8UhPOdPA0B6mk bzKoHo4M6q5JS7dFcPMH9In9VcWFr0ZIYgxKovie8Vi9+aqzhQ8Bav+eipbkAMC3PQoR STEY9RtKkev6xzWzazwJBg1Fea6Ho8EWBSbThyOCfR9/GzDJt61smlcOBwsjVe6bndjq YJf1ScH0SfT2riWx7wMrIqMdJFbX5dfRFHV06CIaUgz81MzuHGcKAV2tzqvXhe5YI2n8 zIHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LxXmFLls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si3516101edn.390.2020.10.08.06.29.55; Thu, 08 Oct 2020 06:30:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LxXmFLls; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730264AbgJHNYv (ORCPT + 99 others); Thu, 8 Oct 2020 09:24:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60116 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729810AbgJHNYv (ORCPT ); Thu, 8 Oct 2020 09:24:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602163490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4Udupsb/n1o2VfYDaX1x29f+NgYQ2LOLwGNy4Q7PY2E=; b=LxXmFLlsx96Y1yjScf3rcwtqNNtVWXstwnWDNsrs5b8Wxxo8cv5w85ayP/KlKzS0puMCkX Wqx/VYaO99Zmo9ayZutFGMA0Ukuh8eysjL+cVVwVUWfQP3Ps4vp9F8dqwYtjpXTpPCFb6f mn3XL91wuaKMKkHsCv2dc023KvxG27E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-ctcnHB4eNPWFuYNpHtqVPw-1; Thu, 08 Oct 2020 09:24:48 -0400 X-MC-Unique: ctcnHB4eNPWFuYNpHtqVPw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26F03425D1; Thu, 8 Oct 2020 13:24:47 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.132]) by smtp.corp.redhat.com (Postfix) with SMTP id B24B360BFA; Thu, 8 Oct 2020 13:24:45 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Thu, 8 Oct 2020 15:24:46 +0200 (CEST) Date: Thu, 8 Oct 2020 15:24:44 +0200 From: Oleg Nesterov To: Jens Axboe Cc: linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, peterz@infradead.org, tglx@linutronix.de Subject: Re: [PATCH 2/6] kernel: add task_sigpending() helper Message-ID: <20201008132444.GF9995@redhat.com> References: <20201005150438.6628-1-axboe@kernel.dk> <20201005150438.6628-3-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201005150438.6628-3-axboe@kernel.dk> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05, Jens Axboe wrote: > > @@ -4447,7 +4447,7 @@ SYSCALL_DEFINE0(pause) > __set_current_state(TASK_INTERRUPTIBLE); > schedule(); > } > - return -ERESTARTNOHAND; > + return task_sigpending(current) ? -ERESTARTNOHAND : -ERESTARTSYS; > } > > #endif > @@ -4462,7 +4462,7 @@ static int sigsuspend(sigset_t *set) > schedule(); > } > set_restore_sigmask(); > - return -ERESTARTNOHAND; > + return task_sigpending(current) ? -ERESTARTNOHAND : -ERESTARTSYS; > } Both changes are equally wrong. Why do you think sigsuspend() should ever return -ERESTARTSYS ? If get_signal() deques a signal, handle_signal() will restart this syscall if ERESTARTSYS, this is wrong. Oleg.