Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1301158pxu; Thu, 8 Oct 2020 08:13:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiw7/XrKTnEiG30uur60YDI/iGv533QeZmlWrA0y77NN72gU0ksGl1RyVY1ut5qO6a5xB7 X-Received: by 2002:a50:fe93:: with SMTP id d19mr9291855edt.323.1602170037099; Thu, 08 Oct 2020 08:13:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602170037; cv=none; d=google.com; s=arc-20160816; b=l8uQKR0FthJGtmauzhkYrdVTBHnxgB5XM5praaV1D6IyRmM9JbT9GEDLNiNdbQeOJ8 d4aEF72pY5zyQxAvIyiY2c6KMkQa2/L3htBSDeeCBfT5kmkdGNZFDdKHWTTqj4Y731ht NBebnu4MqX26JjqoSQRVNOmcD42UmS87qridnljim1pqZ3o7MrBdOnlO2AVDdzrbJI/L ES4UzA/mxUJ28UeRej2JtKwuexREqScFQkcRgHnKTZ8oxkTGUNEZsLmMG11+9PaoVhVR FH88bJrDYJgQQdxROWyMu2D/OKUI5aH7yINWr+tzEkhh2+8LdyJjh1aUq/npkbDnvpYc z+rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=04cZsQfKzTfQN0B6z+PUGGKYvOq91/ycjZEHztk+12I=; b=Da7EOUZIV6oM1EQEwXDKPl7l3iKX/+V8su3aY5n2vwr8NKyXRw/E7E5CK8p+VD7Qnm ZwevwqJneBFFUSha+lYKCw3wK5FvERBTPvps1/2It5JXijsijxvSLSrJrrpJqlzVKf0A 3wW+18cxxBLRK1KBIHvsiF3wzd26aFldf7wKaQ4OWr8BXLTCvHE5Ef2UnYs5CwyzjifL 7XktTl6IM2gZ0s/JSeoaJm+wFRonqWnlv13+eD+aAYLSAwaoTDXTtUZTwsQVvqdX8XEJ XRqYXIhc769ZaHebalZqaW0G1SsW/he/3pVUrDEuhO+dek92oDBe7Cm9mjC3Fg2vm0wC 7xeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=akJaisRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bt21si3899903edb.243.2020.10.08.08.13.31; Thu, 08 Oct 2020 08:13:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=akJaisRs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730908AbgJHPKw (ORCPT + 99 others); Thu, 8 Oct 2020 11:10:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730843AbgJHPKw (ORCPT ); Thu, 8 Oct 2020 11:10:52 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34C85C061755 for ; Thu, 8 Oct 2020 08:10:52 -0700 (PDT) Received: from zn.tnic (p200300ec2f0a9000bfab7746bad7d6a7.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:9000:bfab:7746:bad7:d6a7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BD73B1EC047E; Thu, 8 Oct 2020 17:10:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1602169850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=04cZsQfKzTfQN0B6z+PUGGKYvOq91/ycjZEHztk+12I=; b=akJaisRsFP+XQyfDRYBAaT8uvOrB7fzB1bQNEER/2tb9tgajsp7p8sQAtUU/SopqBDlMv0 DcXkWOqlOPP+sJKnHaH25om3mbrzvZE/FmEvQSbdiLFK0v+hkrfz7qn0jCWbiZkZG2O4Sk 8hxuShhoj976FO2/UiAJRL5Ke+LeHgQ= Date: Thu, 8 Oct 2020 17:10:47 +0200 From: Borislav Petkov To: Arvind Sankar Cc: x86@kernel.org, Joerg Roedel , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] x86/boot: Move get_cmd_line_ptr() and COMMAND_LINE_SIZE into misc.h Message-ID: <20201008151047.GB5505@zn.tnic> References: <20201007195351.776555-1-nivedita@alum.mit.edu> <20201007195351.776555-3-nivedita@alum.mit.edu> <20201008093042.GA6491@zn.tnic> <20201008134723.GB2429573@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201008134723.GB2429573@rani.riverdale.lan> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 09:47:23AM -0400, Arvind Sankar wrote: > Are you ok with the include of setup.h? Or you could simply add cmdline.h and include that. It is high time we started cleaning up that include hell in compressed/ and all facilities there be nicely separated. Recently I started untangling it but it is a serious mess. And kernel proper includes leak in there, yuck. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette