Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200930171512.3986425-1-jolsa@kernel.org> <20200930171512.3986425-2-jolsa@kernel.org>
 <20201001190530.GD3999500@krava> <CAM9d7chyjSaqhjjT4myfs5p9ExH-3Rugme-OFaF8454yO4_s1w@mail.gmail.com>
 <CAP-5=fW=y4jJJfcY81wa8zjUXfOJrun=djT5ZL+6W826r4pERg@mail.gmail.com>
 <20201002192944.GH3999500@krava> <CAM9d7cgoaU4wcid46+uScFcZtMZZQR+fijuE7XO1mjC2cLwX-A@mail.gmail.com>
 <20201008091153.GB656950@krava>
In-Reply-To: <20201008091153.GB656950@krava>
From:   Ian Rogers <irogers@google.com>
Date:   Thu, 8 Oct 2020 08:22:23 -0700
Message-ID: <CAP-5=fWM4X_AaFWc97s2m2KpEo7veE01gN9YQtnawbqQU=YH7w@mail.gmail.com>
Subject: Re: [PATCHv2 1/9] perf tools: Add build id shell test
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Stephane Eranian <eranian@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 8, 2020 at 2:12 AM Jiri Olsa <jolsa@redhat.com> wrote:
>
> On Tue, Oct 06, 2020 at 10:37:45AM +0900, Namhyung Kim wrote:
> > On Sat, Oct 3, 2020 at 4:29 AM Jiri Olsa <jolsa@redhat.com> wrote:
> > >
> > > On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote:
> > >
> > > SNIP
> > >
> > > > > > +
> > > > > >  LIBJVMTI = libperf-jvmti.so
> > > > > >
> > > > > >  ifndef NO_JVMTI
> > > > > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-map.c
> > > > > >         $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c
> > > > > >  endif
> > > > > >
> > > > > > +ifndef NO_BUILDID_EX
> > > > > > +$(OUTPUT)buildid-ex-sha1:
> > > > > > +       $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=sha1 -o $@ -x c -
> > > > > > +$(OUTPUT)buildid-ex-md5:
> > > > > > +       $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=md5 -o $@ -x c -
> > > > > > +endif
> > > > >
> > > > > Can we just build them in the test shell script instead?
> > >
> > > it would solve the build-directory/install-directory
> > > lookup search.. but it'd need to do detect compiler
> > > and depend on it as Ian said
> > >
> > > do you have some other reason to compile it in test?
> >
> > No I just wanted to make it easy to find the binaries
> > and assumed a compiler is available in the test machine
> > (which is not true for my company setup.... :-/)
> >
> > But otherwise we should keep the binaries somewhere
> > in the install directory..
>
> hum, could we go in with the v3 and then you guys
> could customize it to what would work for you?

v3 is fine with me, it is progress to have a test. Longer term I hope
we can have binary dependencies on shell tests and get them installed,
etc. libperf would be a motivating case.

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> thanks,
> jirka
>