Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Oct 2020 17:13:15 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Michal Suchanek <msuchanek@suse.de>
Cc:     linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun8i: h2+: Enable optional SPI flash on
 Orange Pi Zero board
Message-ID: <20201008151315.v3geykbs6musl4wq@gilmour.lan>
References: <20200929083025.2089-1-msuchanek@suse.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3jq5ty6aibw6pauv"
Content-Disposition: inline
In-Reply-To: <20200929083025.2089-1-msuchanek@suse.de>
Precedence: bulk


--3jq5ty6aibw6pauv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Sep 29, 2020 at 10:30:25AM +0200, Michal Suchanek wrote:
> The flash is present on all new boards and users went out of their way
> to add it on the old ones.
>=20
> Enabling it makes a more reasonable default.
>=20
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
>  arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts b/arch/arm=
/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> index f19ed981da9d..061d295bbba7 100644
> --- a/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> +++ b/arch/arm/boot/dts/sun8i-h2-plus-orangepi-zero.dts
> @@ -163,8 +163,8 @@ &ohci1 {
>  };
> =20
>  &spi0 {
> -	/* Disable SPI NOR by default: it optional on Orange Pi Zero boards */
> -	status =3D "disabled";
> +	/* Enable optional SPI NOR by default */
> +	status =3D "okay";
> =20
>  	flash@0 {
>  		#address-cells =3D <1>;

Unfortunately, it's optional, so there's really no reason to enable it
all the time. If it's troublesome to users, then the distros or vendors
should make the changes necessary to the hardware, bootloader or their
documentation to make it easier for those users.

Maxime

--3jq5ty6aibw6pauv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX38siwAKCRDj7w1vZxhR
xcSAAP9PvkQx5Q81Zhhvzgn+tmPzl7bCxG1cUlqZZ+/JGJt+TwD+KubY5HG4h852
7ppZm294af5hYuKgY0iPbBpYbxNuYgk=
=OfOL
-----END PGP SIGNATURE-----

--3jq5ty6aibw6pauv--