Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Peter Korsgaard <jacmet@gmail.com>
From:   Peter Korsgaard <peter@korsgaard.com>
To:     Sagar Kadam <sagar.kadam@openfive.com>
Cc:     "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-riscv\@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-i2c\@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "andrew\@lunn.ch" <andrew@lunn.ch>,
        "Paul Walmsley \( Sifive\)" <paul.walmsley@sifive.com>,
        "palmer\@dabbelt.com" <palmer@dabbelt.com>,
        "aou\@eecs.berkeley.edu" <aou@eecs.berkeley.edu>
Subject: Re: [PATCH 1/1] i2c: ocores: fix polling mode workaround on FU540-C000 SoC
References: <1602006796-273724-1-git-send-email-sagar.kadam@sifive.com>
        <1602006796-273724-2-git-send-email-sagar.kadam@sifive.com>
        <87imbm4639.fsf@dell.be.48ers.dk>
        <DM6PR13MB345137AD526D0AAA6CE0DBDF970B0@DM6PR13MB3451.namprd13.prod.outlook.com>
Date:   Thu, 08 Oct 2020 18:05:30 +0200
In-Reply-To: <DM6PR13MB345137AD526D0AAA6CE0DBDF970B0@DM6PR13MB3451.namprd13.prod.outlook.com>
        (Sagar Kadam's message of "Thu, 8 Oct 2020 13:53:55 +0000")
Message-ID: <87eem84sad.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>>>>> "Sagar" == Sagar Kadam <sagar.kadam@openfive.com> writes:

 > Hello Peter,
 >> Are both affected by this issue? if not, we will need to extend the code
 >> to handle them differently.
 >> 

 > No, this issue is present in FU540-C000 SoC i.e SoC- specific, and so I can check 
 > for the soc-compatible string as follows:

 > -       match = of_match_node(ocores_i2c_match, pdev->dev.of_node);
 > -       if (match && (long)match->data == TYPE_SIFIVE_REV0)
 > +       if (of_device_is_compatible(pdev->dev.of_node,
 > +                                       "sifive,fu540-c000-i2c"))

 > Please let me know if this is okay.

Yes, that sounds sensible. Thanks.

-- 
Bye, Peter Korsgaard