Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1549713pxu; Thu, 8 Oct 2020 14:34:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw8R+XF2BR5Ap62yjiR7upX/kZ+zo7VFkwbKJbWXurDgcdbSdxgTb/jLMcfo/rg860pBeDr X-Received: by 2002:aa7:de82:: with SMTP id j2mr11772942edv.3.1602192865839; Thu, 08 Oct 2020 14:34:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602192865; cv=none; d=google.com; s=arc-20160816; b=Bt+bCMNXDVJMWbGOVNSqaxaJjpJI5Q3fpp4p2OPM58qfx041ieTrb+lFedsCdKuFca wxSF21UaY4Gb7y+KFErvc3xa50zgQe+rZ8uMJsinr17YYc4+Gie3vEsDQjnQhoUIl7Gc /I+B04oKhuZvvv6FMXBdmsjG1HLHw+wfiMtgNAgmVUIWMkZp7qxv6ZDgIschIikeWLih vdUC2HsBlv3UU6S6vQ63x7i3fLXaX+yhGPzqHgB+DyIfN4hnSrdeIozgbQbytae113lI HjYKyDhHlnj5Ct1icEJQMaUx9tZ2RlvDFiGNYQjxtkhD6Xja/T6NCRevCnZvbPiIFTUO L+Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WreWDI35pT37NfCuOvWMpspZ2aPXJW/j5j611lagGSs=; b=IB97I3pM9N3F82y2DLecW40lvan20zoOv+RayBMy/+nv6RJJe0yq6Hp3de+O/HEaY7 jar3az8gdX5vl5elzrtqNu7AWsnoEwpbVTZYBwigSyrxLsP2SjwM8VBl6FYTM0ozydt/ SqYaTS5AApc8o6xeXwvNpOS1T7kcQGvNUC9S8gYhirg3dXytSbnSij1an5qG7rLI4j1g ItfL5jYqW56niwoNf/Zau5igNbgHWMfsIWbVmb9CctrQMkg3iBVzHYzm8KjhIWPhIgu7 v9e6eHadMpSi8IvbInMowqWfdPaRMmbqU0SpzQWMRTEgi8iRpi88t4akfWu82HMc5pxS 9TDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PZxUJluz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx5si4590372ejb.393.2020.10.08.14.34.03; Thu, 08 Oct 2020 14:34:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PZxUJluz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729999AbgJHUMK (ORCPT + 99 others); Thu, 8 Oct 2020 16:12:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729915AbgJHUMK (ORCPT ); Thu, 8 Oct 2020 16:12:10 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 837B1C0613D2 for ; Thu, 8 Oct 2020 13:12:10 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id w21so4892505pfc.7 for ; Thu, 08 Oct 2020 13:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WreWDI35pT37NfCuOvWMpspZ2aPXJW/j5j611lagGSs=; b=PZxUJluzIt1QggeTdkNp9OGJgg8XkikVmQtKopRptoci+IiyqJqGf+kVkFCc7cjq69 ivlpz04pLJ09uusSJJ4LJMyd47n6LwU643lka2EaG7jq9Mau6Ss7URcohb2Qqly0mG0f trPTzA+vrmzueVq5pWh5d68dBmr+kkEQMWCG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WreWDI35pT37NfCuOvWMpspZ2aPXJW/j5j611lagGSs=; b=DKYHXIhCR54sC61JmIGwl46sYFE/spex/OIsQG1sCqzxuM9FOYmx6U1psUicLzpANA Qke2ZpdWtR2qE6POhIJb9sOG8/gqby4Vm/sF82S+7XC8YSCKo+HLppoejP2vINbxFvN2 9alT4fNIJaVdoQY7KPBC0P3CPFEvyxQ9Y531K0SWNz9iPJKZS/6P0b5CPAEIwbFt+wKO UyeB/BWcNveydr143p5faWJNxgVbh7CcrqCyTGw9w8dvRo4thbWwRx+u/ZWCq+7W7UdZ NCh/pp/RDHxwRZviMLwDROcp7NdVQspn08bv5J7EpXYcfvBaU4jTvHaTE1VijhV19a2X 3iJA== X-Gm-Message-State: AOAM531IiCY8RlXMVAM/RlLibJk9GOFpwImXdp8YvJhTnzrH+HQ0+bR8 gQPi0mG5z1X27YoFfUEbzvD9Mw== X-Received: by 2002:a62:e104:0:b029:152:4f37:99da with SMTP id q4-20020a62e1040000b02901524f3799damr8922475pfh.17.1602187930094; Thu, 08 Oct 2020 13:12:10 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j12sm8341727pjd.36.2020.10.08.13.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 13:12:09 -0700 (PDT) Date: Thu, 8 Oct 2020 13:12:08 -0700 From: Kees Cook To: Tommi Rantala Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Christian Brauner Subject: Re: [PATCH 02/13] selftests: pidfd: fix compilation errors due to wait.h Message-ID: <202010081312.ACFDD219@keescook> References: <20201008122633.687877-1-tommi.t.rantala@nokia.com> <20201008122633.687877-3-tommi.t.rantala@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008122633.687877-3-tommi.t.rantala@nokia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 03:26:22PM +0300, Tommi Rantala wrote: > Drop unneeded header inclusion to fix pidfd compilation > errors seen in Fedora 32: > > In file included from pidfd_open_test.c:9: > ../../../../usr/include/linux/wait.h:17:16: error: expected identifier before numeric constant > 17 | #define P_ALL 0 > | ^ > > Signed-off-by: Tommi Rantala Reviewed-by: Kees Cook -- Kees Cook