Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1553604pxu; Thu, 8 Oct 2020 14:42:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWCGTuntW9alDmewpVMmr/KerFgSRBjKzTqHdCuUuFhB+uFfzMWh4i7CcwIxv8+XqbLICC X-Received: by 2002:aa7:cf93:: with SMTP id z19mr11271203edx.26.1602193335617; Thu, 08 Oct 2020 14:42:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602193335; cv=none; d=google.com; s=arc-20160816; b=OpCY3jSngu0+XrgrIQHyi4K+SV0PHGwk/KhYqKlPGmqpdA3jHB7ACCxSKtsj8v40vh 98fFB7FKABCVk8C7xxt5peDOUac6SisUZPddFN5eDt49KLaxMD3HVllNQMR6Io8m38Ba YYXMCwydbRfv7RfS3x+TDriErRdm0eL7gKMPCdtZAGousvDCbJQD7x/PIICGuCUiu3vY 07UgL+uaFDDzj79ELmwPmD+muvy+5OI22UgTEpQ2CqJkYm+Ev5wDPPfIvApxqVVQ+DM8 tWQFas1ZKTihccJdxXG5xDT8RmGMro9yXFyZinzLGyqYLviNXQDCLMURei6OJUCud5fG PwxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=YIDcw7NlsalCPVtLAWvtPQQXkYvESSJbyPbOKMFjQWw=; b=KBIHxw2Cwzk6g2/1I1D9J7OvXchdUOMIMqYue7lUPyJ99/lvOD6uOFT4Hzgkyx+ZFi 0PU+qxuBftmulJdQcmykVlg1ZBLRw73XUrMmJ06v5Wdu4Cuz68WboMMrzi1zjLQi1pxT m/bq6Jf8a7yZ4AEbMMthZ7SO6xNhihmSX26heBqmVDhpIlxJueFhGT31fWy5PD8+24fC a+AxcA4WdVMNNFaDt1+rB+1Xrc9/a9cwFcrhU4T8kzj+zjMXHUNYVKfu8/v+EJozd9h6 0Qmwb8wrr0/ZxqDGxfK/yjqyxWq/kKcgmtkXfYoOQVveTCzR2uun7bT/wyPPte8/0/x/ g+sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=osB4uMM8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s21si4645256edi.88.2020.10.08.14.41.52; Thu, 08 Oct 2020 14:42:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=osB4uMM8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730723AbgJHUvO (ORCPT + 99 others); Thu, 8 Oct 2020 16:51:14 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:55772 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725931AbgJHUvN (ORCPT ); Thu, 8 Oct 2020 16:51:13 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 098Ko26L178180; Thu, 8 Oct 2020 20:51:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=YIDcw7NlsalCPVtLAWvtPQQXkYvESSJbyPbOKMFjQWw=; b=osB4uMM8fN3Yckym+cLKX8G8k06fEs4gvIfAklYO9/KMPIIzNuoqGFI+WKMurpPdLYSs 3no8kS/t+EIYLAzvuz6GPC93H5QpQNZEn5u4C6Hr4H6Pfr+PUCswTeCVInnuTsazGy2m nP52XImXTtzvpgvUlpy9sL4P92UwBisYBFZrZhhuKqPgHaYVDpBFa6zOALzKaKh900hg YCwQwm/V6g68lahmPuPXDl6hJpRYVKdgCunr4gPGaVcX4CGTxt0Qu5naiVyrw9tF9cxt v1a7SerzadqDnLIKmkkV5ITZj/iV0MvsOVpiIxfHGtf3FurSnXTLUVT2gSSjEgcXKWwt OQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 3429jur6xn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 08 Oct 2020 20:51:06 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 098Kitxk117452; Thu, 8 Oct 2020 20:51:06 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 3429kah2bk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Oct 2020 20:51:05 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 098Koxbo014917; Thu, 8 Oct 2020 20:50:59 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Oct 2020 13:50:58 -0700 To: Colin King Cc: Nilesh Javali , GR-QLogic-Storage-Upstream@marvell.com, "James E . J . Bottomley" , "Martin K . Petersen" , Himanshu Madhani , Pavel Machek , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla2xxx: fix return of uninitialized value in rval From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <20201008183239.200358-1-colin.king@canonical.com> Date: Thu, 08 Oct 2020 16:50:56 -0400 In-Reply-To: <20201008183239.200358-1-colin.king@canonical.com> (Colin King's message of "Thu, 8 Oct 2020 19:32:39 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9768 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 adultscore=0 phishscore=0 spamscore=0 mlxscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010080147 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9768 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=1 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010080147 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin, > A previous change removed the initialization of rval and there is now > an error where an uninitialized rval is being returned on an error > return path. Fix this by returning -ENODEV. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering