Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751100AbWHIQKv (ORCPT ); Wed, 9 Aug 2006 12:10:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751099AbWHIQKv (ORCPT ); Wed, 9 Aug 2006 12:10:51 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:52931 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751101AbWHIQKu (ORCPT ); Wed, 9 Aug 2006 12:10:50 -0400 Date: Wed, 9 Aug 2006 17:10:39 +0100 From: Christoph Hellwig To: David Smith Cc: Christoph Hellwig , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, shemminger@osdl.org Subject: Re: [PATCH 1/3] Kprobes: Make kprobe modules more portable Message-ID: <20060809161039.GA30856@infradead.org> Mail-Followup-To: Christoph Hellwig , David Smith , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, shemminger@osdl.org References: <20060807115537.GA15253@in.ibm.com> <20060808162421.GA28647@infradead.org> <1155139305.8345.20.camel@dhcp-2.hsv.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1155139305.8345.20.camel@dhcp-2.hsv.redhat.com> User-Agent: Mutt/1.4.2.1i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 31 On Wed, Aug 09, 2006 at 11:01:45AM -0500, David Smith wrote: > > + if (p->symbol_name) { > > + if (p->addr) > > + return -EINVAL; > > + p->addr = kprobe_lookup_name(p->symbol_name) + p->offset; > > + } > > What if kprobe_lookup_name() fails for that case we need the check in your snipplet below. > or if CONFIG_KALLSYMS isn't set? I think we should just disallow that case. having kprobes without kallsyms is rather pointless. I'll send a patch to add the dependency to the Kconfig files. > Perhaps this needs something like: > > if (p->symbol_name) { > if (p->addr) > return -EINVAL; > p->addr = kprobe_lookup_name(p->symbol_name) + p->offset; > if (p->addr == p->offset) > return -EINVAL; > } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/