Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1850125pxu; Fri, 9 Oct 2020 01:02:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUnH2dhd1i1KvEFZ8FLAR23hzh6j42/RFMZDSHceO6VWZudZNMUpmrnKJdSq8fgJAxjhfD X-Received: by 2002:aa7:d1cc:: with SMTP id g12mr13351721edp.195.1602230529877; Fri, 09 Oct 2020 01:02:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602230529; cv=none; d=google.com; s=arc-20160816; b=f6drdVa8jge4vVuwwyjovJearBzA/h4UtRZyrrQBvYGOIic5VqdWVWUJlTCzVsheV+ Ss432IykTA8473TFsLnu6kb1QeD5n5mV20noQ6LfP0dIAdcZwdsjuiGm+6OerXf+mh7P 32Vdr13FEilMiOvvg4Hz7gGFVYK7ztfMj6lBPHNe1FoertXX8k+NRLbaobRrbglJCrJS 03t7/UHfwhrc12YWjXcNcswcBhSEA743UoBuT6CifMwHJqzAo2sUQy6kbQWxDpWLwPbf m0+Y8ZBxUkfAHTMBA/ov25frJg5lUwaIXB4G8/8G7GIU27UpCttpoDiRGC8P/jpv1lPg r1Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=immTPDdSm8V7ezbOteojXYm/j7WkY1f3P9Y0YpK7onQ=; b=HHA5nnJhmMx1V/JUDmFZhGlbgXsFs+9iUvq/P4E0pfR/Zr5Lmb2tFcPDFyNwi4FLlr J7IbwSszUWe8IlBEm5/N/VXjEgidvUYtMF/ZWS0meJIEt6OOCOrXSEYagipoxSt7I00Y Fw63zlanznooey9ABgcEt+Nct3Hf9YS6vUO6mPtatSwjWSA6G/YWDghM/PLWhRcmBkSJ yfm0fMdJNFB02iIgRDlg22HU14BjKAZ2lgfsH7JdPm3pxBosRR+mb5lqMm8Do4O2vMq+ vlrDjCwnvPQBNCErX6uw9APDDMuNaueYEnGNyLrxA388q2FA0+9WG7B2sCbfubQbWyO9 E9zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="DEazGm3/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 16si5281401edv.551.2020.10.09.01.01.46; Fri, 09 Oct 2020 01:02:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b="DEazGm3/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732488AbgJIIAD (ORCPT + 99 others); Fri, 9 Oct 2020 04:00:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732645AbgJIH7x (ORCPT ); Fri, 9 Oct 2020 03:59:53 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A28C0613D7 for ; Fri, 9 Oct 2020 00:59:53 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id d81so8863985wmc.1 for ; Fri, 09 Oct 2020 00:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=immTPDdSm8V7ezbOteojXYm/j7WkY1f3P9Y0YpK7onQ=; b=DEazGm3//HS7eifrtPTNpv9gPNwxpuxjM7cgzXbcLG0mO5e39cJ73eX9iQKQEkxr4Y FwEAxZ/eknqujf87zOGqp6tESSOeL2I6VSIobgrZsNnXiWlr9VWW7WhVnV0GrVhO4vMj 1v4YtSGCDuC7IGf+ELUEOwyj9sMdI3c9bq3Xg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=immTPDdSm8V7ezbOteojXYm/j7WkY1f3P9Y0YpK7onQ=; b=sTK2T9XCdxehGTs9SwZfr0Ew7B/EpXKXbWzMVSATvDFNtNOyeL5knGcFVySgtkOYWU S/Shxpca4SsUm6f00b+dW7GvVQBzPB0e3GF+UadDIXW5hdYCQxAAnilC1z4g63K3RtzA UtakZcYN06a4UAPTkN1bZZAoYaX2TNVOrYBYwOVDUYPBByYawhqqTSLb2QeByLOjvCAm sWohI2cUgtecyrHMemvwS016gPDj4fJWx1SnloiOg5AKnZjN70Zd/p5u5rkB1g9dnFs2 W/78+GEAu39k4yUajrEzrblsF+nIihY63Y71KoOEFcd1Smo9c6ejLRVN2gM7l1j9sUtN roIw== X-Gm-Message-State: AOAM532voEVytbjnHTYD8ha287SFH2sJOxwtN98FAHtn+lxLOJJamfe/ RDPhgHBtb9KMg/Kp0iYyEOID8A== X-Received: by 2002:a1c:f311:: with SMTP id q17mr13703008wmq.168.1602230391713; Fri, 09 Oct 2020 00:59:51 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id u17sm11634118wri.45.2020.10.09.00.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 00:59:50 -0700 (PDT) From: Daniel Vetter To: DRI Development , LKML Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, Daniel Vetter Subject: [PATCH v2 00/17] follow_pfn and other iomap races Date: Fri, 9 Oct 2020 09:59:17 +0200 Message-Id: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, Round two of my patch series to clamp down a bunch of races and gaps around follow_pfn and other access to iomem mmaps. Previous version: v1: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ And the discussion that sparked this journey: https://lore.kernel.org/dri-devel/20201007164426.1812530-1-daniel.vetter@ffwll.ch/ Changes in v2: - tons of small polish&fixes all over, thanks to all the reviewers who spotted issues - I managed to test at least the generic_access_phys and pci mmap revoke stuff with a few gdb sessions using our i915 debug tools (hence now also the drm/i915 patch to properly request all the pci bar regions) - reworked approach for the pci mmap revoke: Infrastructure moved into kernel/resource.c, address_space mapping is now set up at open time for everyone (which required some sysfs changes). Does indeed look a lot cleaner and a lot less invasive than I feared at first. The big thing I can't test are all the frame_vector changes in habanalbas, exynos and media. Gerald has given the s390 patch a spin already. Review, testing, feedback all very much welcome. Cheers, Daniel Daniel Vetter (17): drm/exynos: Stop using frame_vector helpers drm/exynos: Use FOLL_LONGTERM for g2d cmdlists misc/habana: Stop using frame_vector helpers misc/habana: Use FOLL_LONGTERM for userptr mm/frame-vector: Use FOLL_LONGTERM media: videobuf2: Move frame_vector into media subsystem mm: Close race in generic_access_phys s390/pci: Remove races against pte updates mm: Add unsafe_follow_pfn media/videbuf1|2: Mark follow_pfn usage as unsafe vfio/type1: Mark follow_pfn as unsafe PCI: Obey iomem restrictions for procfs mmap /dev/mem: Only set filp->f_mapping resource: Move devmem revoke code to resource framework sysfs: Support zapping of binary attr mmaps PCI: Revoke mappings like devmem drm/i915: Properly request PCI BARs arch/s390/pci/pci_mmio.c | 98 +++++++++++-------- drivers/char/mem.c | 86 +--------------- drivers/gpu/drm/exynos/Kconfig | 1 - drivers/gpu/drm/exynos/exynos_drm_g2d.c | 48 ++++----- drivers/gpu/drm/i915/intel_uncore.c | 25 ++++- drivers/media/common/videobuf2/Kconfig | 1 - drivers/media/common/videobuf2/Makefile | 1 + .../media/common/videobuf2}/frame_vector.c | 54 ++++------ drivers/media/platform/omap/Kconfig | 1 - drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +- drivers/misc/habanalabs/Kconfig | 1 - drivers/misc/habanalabs/common/habanalabs.h | 3 +- drivers/misc/habanalabs/common/memory.c | 50 ++++------ drivers/pci/pci-sysfs.c | 4 + drivers/pci/proc.c | 6 ++ drivers/vfio/vfio_iommu_type1.c | 4 +- fs/sysfs/file.c | 11 +++ include/linux/ioport.h | 6 +- include/linux/mm.h | 47 +-------- include/linux/sysfs.h | 2 + include/media/videobuf2-core.h | 42 ++++++++ kernel/resource.c | 95 +++++++++++++++++- mm/Kconfig | 3 - mm/Makefile | 1 - mm/memory.c | 76 +++++++++++++- mm/nommu.c | 17 ++++ security/Kconfig | 13 +++ 27 files changed, 412 insertions(+), 286 deletions(-) rename {mm => drivers/media/common/videobuf2}/frame_vector.c (85%) -- 2.28.0