Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200825162718.5838-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
 <20200825162718.5838-2-prabhakar.mahadev-lad.rj@bp.renesas.com> <20201009072350.GB10335@amd>
In-Reply-To: <20201009072350.GB10335@amd>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Fri, 9 Oct 2020 10:01:02 +0100
Message-ID: <CA+V-a8uw7+U=cnqQqiHAt4z6BzrSKQdAC01JKvgcry9y23Vd5A@mail.gmail.com>
Subject: Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller
To:     Pavel Machek <pavel@denx.de>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Pavel,

Thank you for the review.

On Fri, Oct 9, 2020 at 8:23 AM Pavel Machek <pavel@denx.de> wrote:
>
> Hi!
>
> > +&pciec {
> > +     /* SW2[6] determines which connector is activated
> > +      * ON = PCIe X4 (connector-J7)
> > +      * OFF = mini-PCIe (connector-J26)
> > +      */
> > +     status = "okay";
> > +};
>
> Note this is wrong comment style for non-network parts of kernel.
>
Good point, i'll fix that.

Cheers,
Prabhakar