Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp1950544pxu; Fri, 9 Oct 2020 04:15:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIpi5GXUxyIZqWvd3SJbRnKGLHU7zBOTXVBdmW+4NCHFvrQfDHjq5Ktutohobtp4IQ+WVe X-Received: by 2002:a17:906:a988:: with SMTP id jr8mr13603569ejb.508.1602242122966; Fri, 09 Oct 2020 04:15:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602242122; cv=none; d=google.com; s=arc-20160816; b=PcvWsQmyjOs+fUgvsAFneFSPF6A5dBnRsmrdHeJOjIcJ5cb97vppJ1TXGAkLyiLPuP VCFc8WVsE8PO8o8yfo3QQGoKA8AJRpApUxN/ga1pzcyIHY8lwK4izU8gaViacNhHqg4Z lmkqFEpGfYAKtDlWI0qutVAa0XPXkmpU8GSE1CfDHUWHaLpO+0Xl8wnEorHx9Uy9EXCq oJl6m0f2L1NkGPSkTmdTc7tX7xiZK/HDa357tss7S/oniXAmEth4/DQGFvxDw1YMZzX2 jvUV/+IoveIT+xCL4QSPf2TjdeuvzPM3EEYG7X68870vUaswshYUvpt08vQU3AIQVQmq 1SnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2tjwKjyhjlFB+xE6wJz2X+X61/PU1cwjg8RCFYDQROU=; b=xtLTYGIYvG+tXgy/pzxrrTDcF9SEqhOcafeOztnShGRn+8F53JzYmO+OM13MvEcI5O +6NG7oK/UbQfrWIQ0u363WqBz+ShUeynqL9fPLIR9zluAL2JD8bjn/WzVvC6GD4iZM/Z ghhnAMFxy4ieZd8qcZvLg1hXwOvIWwGxJBG5bxDvbk0Cv3+EW1ZAk20QU0SwITXR/tPt C6BWMfIHqWIFmKngn8+6YiNV6vd9sbb0tjDv+ApIEMEi/hN/KCN5lcL/3zwS9x0BA6T1 JSU1X1Hri3MgwC8kFdzf8zSJd4U+1pirFLMwIpmzcCqt//JSIaNH1GgXhuYUciB/W+yE aMJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tq0xt+Nj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d2si5943837ejm.262.2020.10.09.04.14.55; Fri, 09 Oct 2020 04:15:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tq0xt+Nj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731827AbgJIHU4 (ORCPT + 99 others); Fri, 9 Oct 2020 03:20:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:44776 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbgJIHU4 (ORCPT ); Fri, 9 Oct 2020 03:20:56 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA7D322244; Fri, 9 Oct 2020 07:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602228055; bh=zIymCSHg9Zg+z9GLKQbc3ItuquT9CYWzArm0DOFUUoI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tq0xt+Nj7bKX0IcFmLIcPoPZcfdELavFD7QDp0QLmuFCy5I77+nFLPbz94RDcOasl abJmGXK82DmAQLJSj7lATakLmj1QgQL+idU2cELdRtn3zw+9C8kvf3zqff2ZqkhcEy owFFKDs7GEWMZtFxuyJFiTRKgXG8TcAcu4GyPcvE= Date: Fri, 9 Oct 2020 09:21:41 +0200 From: Greg KH To: Pavel Machek Cc: Jarkko Sakkinen , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Matthew Wilcox , Jethro Beekman , Haitao Huang , Chunyang Hui , Jordan Hand , Nathaniel McCallum , Seth Moore , Darren Kenny , Sean Christopherson , Suresh Siddha , andriy.shevchenko@linux.intel.com, asapek@google.com, bp@alien8.de, cedric.xing@intel.com, chenalexchen@google.com, conradparker@google.com, cyhanish@google.com, dave.hansen@intel.com, haitao.huang@intel.com, kai.huang@intel.com, kai.svahn@intel.com, kmoy@google.com, ludloff@google.com, luto@kernel.org, nhorman@redhat.com, puiterwijk@redhat.com, rientjes@google.com, tglx@linutronix.de, yaozhangx@google.com, mikko.ylinen@intel.com Subject: Re: [PATCH v39 11/24] x86/sgx: Add SGX enclave driver Message-ID: <20201009072141.GA12545@kroah.com> References: <20201003045059.665934-1-jarkko.sakkinen@linux.intel.com> <20201003045059.665934-12-jarkko.sakkinen@linux.intel.com> <20201003143925.GB800720@kroah.com> <20201009071045.GA10335@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009071045.GA10335@amd> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 09:10:45AM +0200, Pavel Machek wrote: > Hi! > > > > new file mode 100644 > > > index 000000000000..f54da5f19c2b > > > --- /dev/null > > > +++ b/arch/x86/kernel/cpu/sgx/driver.c > > > @@ -0,0 +1,173 @@ > > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > > > You use gpl-only header files in this file, so how in the world can it > > be bsd-3 licensed? > > > > Please get your legal department to agree with this, after you explain > > to them how you are mixing gpl2-only code in with this file. > > This specifies license of driver.c, not of the headers included. Are > you saying that it is impossible to have a kernel driver with anything > else than GPL-2? That would be news to many, and that's not what > current consensus is. If you want to write any non-GPL-2-only kernel code, you had better be consulting your lawyers and get very explicit instructions on how to do this in a way that does not violate any licenses. I am not a lawyer, and will not be giving you any such advice, as I think it's not something that people should be doing. greg k-h