Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201009085106.125079-1-nixiaoming@huawei.com>
In-Reply-To: <20201009085106.125079-1-nixiaoming@huawei.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 9 Oct 2020 10:52:31 +0200
Message-ID: <CAMj1kXFfN-dFAu+veu_0j2KAqWisZ8hy-1f3S4Y88tHC7bxxHA@mail.gmail.com>
Subject: Re: [PATCH] efi:mokvar-table: fix build error
To:     Xiaoming Ni <nixiaoming@huawei.com>
Cc:     linux-efi <linux-efi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        wangle6@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 9 Oct 2020 at 10:51, Xiaoming Ni <nixiaoming@huawei.com> wrote:
>
> drivers/firmware/efi/mokvar-table.c:139:5: error: implicit declaration of
>  function 'early_memunmap'; did you mean 'devm_memunmap'?
>  [-Werror=implicit-function-declaration]
> drivers/firmware/efi/mokvar-table.c:148:9: error: implicit declaration of
>  function 'early_memremap'; did you mean 'devm_memremap'?
>  [-Werror=implicit-function-declaration]
>
> add #include <asm/early_ioremap.h> to fix this build error
>
> Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>

Thank you Xiaoming. We already have a fix queued up for this issue.

> ---
>  drivers/firmware/efi/mokvar-table.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/mokvar-table.c b/drivers/firmware/efi/mokvar-table.c
> index 72a9e1736fef..c23d3686f1c7 100644
> --- a/drivers/firmware/efi/mokvar-table.c
> +++ b/drivers/firmware/efi/mokvar-table.c
> @@ -39,6 +39,7 @@
>  #include <linux/kobject.h>
>  #include <linux/list.h>
>  #include <linux/slab.h>
> +#include <asm/early_ioremap.h>
>
>  /*
>   * The LINUX_EFI_MOK_VARIABLE_TABLE_GUID config table is a packed
> --
> 2.27.0
>