Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Oct 2020 12:34:07 +0200
From:   Lukas Wunner <lukas@wunner.de>
To:     Sanjay R Mehta <sanmehta@amd.com>
Cc:     Sanjay R Mehta <Sanju.Mehta@amd.com>, bhelgaas@google.com,
        andriy.shevchenko@linux.intel.com, stuart.w.hayes@gmail.com,
        mr.nuke.me@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Add check for DL_ACTIVE bit in
 pciehp_check_link_status()
Message-ID: <20201009103407.GA9629@wunner.de>
References: <1602008668-43646-1-git-send-email-Sanju.Mehta@amd.com>
 <20201006193830.GA32510@wunner.de>
 <7309c7f3-a895-e4aa-578e-444c5d5734d6@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7309c7f3-a895-e4aa-578e-444c5d5734d6@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Thu, Oct 08, 2020 at 12:43:17PM +0530, Sanjay R Mehta wrote:
> On 10/7/2020 1:08 AM, Lukas Wunner wrote:
> > On Tue, Oct 06, 2020 at 01:24:28PM -0500, Sanjay R Mehta wrote:
> I am supposed to use PCI_EXP_LNKSTA_DLLLA bit in my patch but have
> used PCI_EXP_DPC_CAP_DL_ACTIVE.
> 
> The correct code should be as below,
> 
> -     if ((lnk_status & PCI_EXP_LNKSTA_LT) ||
> +     if (((lnk_status & PCI_EXP_LNKSTA_LT) &
> +          !(lnk_status & PCI_EXP_LNKSTA_DLLLA )) ||

So you want to ignore a set Link Training bit if the DLLLA bit is also
set (i.e. the link is up).  Why do you need this?  Is there broken AMD
hardware which fails to clear the Link Training bit when the LTSSM
exits the Configuration/Recovery state?

Again, please note that you need && instead of &.

Thanks,

Lukas

> >> Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
> >> ---
> >>  drivers/pci/hotplug/pciehp_hpc.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c
> >> index 53433b3..81d1348 100644
> >> --- a/drivers/pci/hotplug/pciehp_hpc.c
> >> +++ b/drivers/pci/hotplug/pciehp_hpc.c
> >> @@ -309,7 +309,8 @@ int pciehp_check_link_status(struct controller *ctrl)
> >>
> >>       pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> >>       ctrl_dbg(ctrl, "%s: lnk_status = %x\n", __func__, lnk_status);
> >> -     if ((lnk_status & PCI_EXP_LNKSTA_LT) ||
> >> +     if (((lnk_status & PCI_EXP_LNKSTA_LT) &
> >> +          !(lnk_status & PCI_EXP_DPC_CAP_DL_ACTIVE)) ||
> >>           !(lnk_status & PCI_EXP_LNKSTA_NLW)) {
> >>               ctrl_err(ctrl, "link training error: status %#06x\n",
> >>                        lnk_status);
> >> --
> >> 2.7.4