Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Oct 2020 16:01:23 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     dmaengine@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] dmaengine: qcom: Add GPI dma driver
Message-ID: <20201009103123.GE2968@vkoul-mobl>
References: <20201008123151.764238-1-vkoul@kernel.org>
 <20201008123151.764238-4-vkoul@kernel.org>
 <6d6b4bf8-5610-f1cb-8c9d-f4bb82c93bdb@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6d6b4bf8-5610-f1cb-8c9d-f4bb82c93bdb@ti.com>
Precedence: bulk

On 09-10-20, 12:00, Peter Ujfalusi wrote:
> Hi Vinod,
> 
> On 08/10/2020 15.31, Vinod Koul wrote:
> > This controller provides DMAengine capabilities for a variety of peripheral
> > buses such as I2C, UART, and SPI. By using GPI dmaengine driver, bus
> > drivers can use a standardize interface that is protocol independent to
> > transfer data between memory and peripheral.
> > 
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> >  drivers/dma/qcom/Kconfig     |   12 +
> >  drivers/dma/qcom/Makefile    |    1 +
> >  drivers/dma/qcom/gpi.c       | 2303 ++++++++++++++++++++++++++++++++++
> >  include/linux/qcom-gpi-dma.h |   83 ++
> 
> Would not be better to have the header under include/linux/dma/ ?

Right, makes sense. Will move into include/linux/dma/

Thanks
-- 
~Vinod