Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp2047910pxu; Fri, 9 Oct 2020 06:44:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGJHZVEN7Bd5OD12CRrFLlMbP1OffleoNHF3Dqn/LELPf/HxhVcOrGVg64M+ciGKyKjToG X-Received: by 2002:a50:9e87:: with SMTP id a7mr14621171edf.297.1602251055941; Fri, 09 Oct 2020 06:44:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602251055; cv=none; d=google.com; s=arc-20160816; b=pSRiy6ii5vlfFIrLxuYg62VLMAX5uVKveEVl9kEpRZg9k+bGrm/Ag03dHVYjtTlfZ4 vG/GI6iieRF00GUSI8GHcu9APaPGRr5dG6bocFA9nd7oEIEYOieyD/a6wGS4+sLsxjpF L0qXQWSiUd9yyK2K1Z8XCoJ+4KcV6yzYbH6bxS0c+A44fjmJSczV5OxxnksvqE2/h9uA C6hbpQRyKUCys83WD3R2VdkT+3p3qpXufKclQrPvhia2obVVBxFv0WwN96DTcBcMZU2f LPDdXt3WdlCtbu6If0BXpmGkwnyTmHfN3Jaf6dFjYIckdjxxlELImvq3xxDDSOhPWkT/ 1Cww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hXU4msjQ4GKKjmLNRBNcK2QQBA9Gu3ySn0f+rMPk69U=; b=ePCkasebSNtqmIDVIbXAA1Bu7rk9evyFDiEI9La50L7YmVa8YAa3s6QWjBxTp3BqBO FrZjtauF+OQH1uNNY7sZQ1TM2YOM1ECStQn6F6ecViXO24Xnt/uYiE2Lfgjc1+ZXw5cH PJyj4iEbGHtA9ItOLf/9t685xwaDlluqryizAKTfZqaWkB1plWLYX29I0yEFavZLl8m1 XWYvrs7DTenCJcU3fWQADmw0SLtqSzTEiEDdRW9WMyredq5tu/NiebgopcRV1VCIs3PO ZVnVswHQqWpQ/68L49OYE7ncfjdhypPvuIkOdRfb+nNyorUZUNIYX+X4uE2OawLsf08i efNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y15si5941486edu.407.2020.10.09.06.43.50; Fri, 09 Oct 2020 06:44:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387804AbgJIMvx (ORCPT + 99 others); Fri, 9 Oct 2020 08:51:53 -0400 Received: from elvis.franken.de ([193.175.24.41]:53488 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730740AbgJIMvs (ORCPT ); Fri, 9 Oct 2020 08:51:48 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kQrs7-0002EF-01; Fri, 09 Oct 2020 14:51:43 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 49978C1126; Fri, 9 Oct 2020 14:09:00 +0200 (CEST) Date: Fri, 9 Oct 2020 14:09:00 +0200 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: Serge Semin , Hauke Mehrtens , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, "Maciej W. Rozycki" , Keguang Zhang , John Crispin , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] MIPS: replace add_memory_region with memblock Message-ID: <20201009120900.GB10588@alpha.franken.de> References: <20201008084357.42780-1-tsbogend@alpha.franken.de> <20201008152006.4khkbzsxqmmz76rw@mobilestation> <631aa35e-2575-3ec0-ec0f-7d45e49b8373@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <631aa35e-2575-3ec0-ec0f-7d45e49b8373@flygoat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2020 at 11:00:36AM +0800, Jiaxun Yang wrote: > > > 在 2020/10/8 23:20, Serge Semin 写道: > > [...] > > > >>- add_memory_region(LOONGSON_HIGHMEM_START, > >>- highmemsize << 20, BOOT_MEM_RAM); > >>- > >>- add_memory_region(LOONGSON_PCI_MEM_END + 1, LOONGSON_HIGHMEM_START - > >>- LOONGSON_PCI_MEM_END - 1, BOOT_MEM_RESERVED); > >>- > >>+ memblock_add(LOONGSON_HIGHMEM_START, highmemsize << 20); > >The same question. Is it ok to discard the > >[LOONGSON_PCI_MEM_END+1:LOONGSON_HIGHMEM_START-LOONGSON_PCI_MEM_END-1] region > >removal operation? > Hi all, > > I can confirm this reservation can be removed. thank you for confirming. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]