Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Meyer, Kyle" <kyle.meyer@hpe.com>
To:     "alexander.antonov@linux.intel.com" 
        <alexander.antonov@linux.intel.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
CC:     "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "kan.liang@linux.intel.com" <kan.liang@linux.intel.com>,
        "alexey.budankov@linux.intel.com" <alexey.budankov@linux.intel.com>,
        "ak@linux.intel.com" <ak@linux.intel.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "Anderson, Russ" <russ.anderson@hpe.com>
Subject: Re: [PATCH] perf/x86/intel/uncore: Fix for iio mapping on Skylake
 Server
Thread-Topic: [PATCH] perf/x86/intel/uncore: Fix for iio mapping on Skylake
 Server
Thread-Index: AQHWlYE8WxPO4bs5eE+etvuI0+CzGKmPXWOi
Date:   Fri, 9 Oct 2020 14:11:03 +0000
Message-ID: <DF4PR8401MB1035CE7DBCCD58B531748BC69B080@DF4PR8401MB1035.NAMPRD84.PROD.OUTLOOK.COM>
References: <20200928102133.61041-1-alexander.antonov@linux.intel.com>
In-Reply-To: <20200928102133.61041-1-alexander.antonov@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2933b377-5af8-4e50-0c1f-08d86c5d2893
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 14:11:03.9150
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F3WgNQV6GMZIhBcOi+GE6aoeseEHXmHtWOpvf38uSCQjz9PjWvi27WPFeros9O86cNHZrcJ3OqZo2dBJND3sTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0682
X-OriginatorOrg: hpe.com
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-10-09_06:2020-10-09,2020-10-09 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0
 priorityscore=1501 phishscore=0 malwarescore=0 adultscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0
 clxscore=1011 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2010090103
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Alexander,

Do you plan on supporting multiple segment platforms?

Thanks,
Kyle Meyer

________________________________________
From: alexander.antonov@linux.intel.com <alexander.antonov@linux.intel.com>
Sent: Monday, September 28, 2020 5:21 AM
To: peterz@infradead.org; linux-kernel@vger.kernel.org; x86@kernel.org
Cc: alexander.shishkin@linux.intel.com; kan.liang@linux.intel.com; alexey.b=
udankov@linux.intel.com; ak@linux.intel.com; acme@kernel.org; mingo@redhat.=
com; alexander.antonov@linux.intel.com; Meyer, Kyle; Anderson, Russ
Subject: [PATCH] perf/x86/intel/uncore: Fix for iio mapping on Skylake Serv=
er

From: Alexander Antonov <alexander.antonov@linux.intel.com>

Introduced early attributes /sys/devices/uncore_iio_<pmu_idx>/die* are
initialized by skx_iio_set_mapping(), however, for example, for multiple
segment platforms skx_iio_get_topology() returns -EPERM before a list of
attributes in skx_iio_mapping_group will have been initialized.
As a result the list is being NULL. Thus the warning
"sysfs: (bin_)attrs not set by subsystem for group: uncore_iio_*/" appears
and uncore_iio pmus are not available in sysfs. Clear IIO attr_update
to properly handle the cases when topology information cannot be
retrieved.

Fixes: bb42b3d39781 ("perf/x86/intel/uncore: Expose an Uncore unit to IIO P=
MON mapping")
Reported-by: Kyle Meyer <kyle.meyer@hpe.com>
Suggested-by: Kan Liang <kan.liang@linux.intel.com>
Reviewed-by: Alexei Budankov <alexey.budankov@linux.intel.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Alexander Antonov <alexander.antonov@linux.intel.com>
---
 arch/x86/events/intel/uncore_snbep.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/u=
ncore_snbep.c
index 62e88ad919ff..ccfa1d6b6aa0 100644
--- a/arch/x86/events/intel/uncore_snbep.c
+++ b/arch/x86/events/intel/uncore_snbep.c
@@ -3749,7 +3749,9 @@ static int skx_iio_set_mapping(struct intel_uncore_ty=
pe *type)

        ret =3D skx_iio_get_topology(type);
        if (ret)
-               return ret;
+               goto clear_attr_update;
+
+       ret =3D -ENOMEM;

        /* One more for NULL. */
        attrs =3D kcalloc((uncore_max_dies() + 1), sizeof(*attrs), GFP_KERN=
EL);
@@ -3781,8 +3783,9 @@ static int skx_iio_set_mapping(struct intel_uncore_ty=
pe *type)
        kfree(eas);
        kfree(attrs);
        kfree(type->topology);
+clear_attr_update:
        type->attr_update =3D NULL;
-       return -ENOMEM;
+       return ret;
 }

 static void skx_iio_cleanup_mapping(struct intel_uncore_type *type)

base-commit: a1b8638ba1320e6684aa98233c15255eb803fac7
--
2.19.1