Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Oct 2020 22:14:45 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To:     Bhaumik Bhatt <bbhatt@codeaurora.org>
Cc:     linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
        jhugo@codeaurora.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 09/10] bus: mhi: core: Move to an error state on
 mission mode failure
Message-ID: <20201009164445.GJ4810@Mani-XPS-13-9360>
References: <1600480955-16827-1-git-send-email-bbhatt@codeaurora.org>
 <1600480955-16827-10-git-send-email-bbhatt@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1600480955-16827-10-git-send-email-bbhatt@codeaurora.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Sep 18, 2020 at 07:02:34PM -0700, Bhaumik Bhatt wrote:
> If the host receives a mission mode event and by the time it can get
> to processing it, the register accesses fail implying a connectivity
> error, MHI should move to an error state. This helps avoid longer wait
> times from a synchronous power up perspective and accurately reflects
> the MHI execution environment and power management states.
> 
> Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/pm.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index bce1f62..16c04ab 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -384,10 +384,14 @@ static int mhi_pm_mission_mode_transition(struct mhi_controller *mhi_cntrl)
>  	write_lock_irq(&mhi_cntrl->pm_lock);
>  	if (MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state))
>  		mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
> -	write_unlock_irq(&mhi_cntrl->pm_lock);
>  
> -	if (!MHI_IN_MISSION_MODE(mhi_cntrl->ee))
> +	if (!MHI_IN_MISSION_MODE(mhi_cntrl->ee)) {
> +		mhi_cntrl->pm_state = MHI_PM_LD_ERR_FATAL_DETECT;
> +		write_unlock_irq(&mhi_cntrl->pm_lock);
> +		wake_up_all(&mhi_cntrl->state_event);
>  		return -EIO;
> +	}
> +	write_unlock_irq(&mhi_cntrl->pm_lock);
>  
>  	wake_up_all(&mhi_cntrl->state_event);
>  
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>