Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp2199870pxu; Fri, 9 Oct 2020 10:16:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYfQ5xz/m1K4hQGcQ5vGfTMq+8l5xT6/b4OVteDbsVOqYJnaZjAgjdxIe6+fpOOre5WDjE X-Received: by 2002:a7b:c189:: with SMTP id y9mr14577105wmi.141.1602263782585; Fri, 09 Oct 2020 10:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602263782; cv=none; d=google.com; s=arc-20160816; b=i32nWHaDZBhB8auqEdE1T0mxh3S/Y19hqdwTqefO0zH2drzMLQKbcjuaHkZF31k7fg Kn+HUaf/Yzl1JQ2vyYyH0ZhD+MahHGGkQA4H8qUmD0N97Y22KjcMY+g6QUvTeU9uBefJ SqN68SJ8nmco79MHFV1xucuY5l9f0QilZt5/0KLzM9eVo/ifl9fEEemSTH5kPOazGF3q QhyjzcZyJBnTrjZbftjtbbRvFWQQNInrX4bs7sqjRsTCKxxvna9BRVnY8kBSVwgByR9W 8hXnkjJZf09BAln+CJUNAdZEI/Ch4jAX7a+mjpy3QVx6NK3PZMuuZTq5UXVjvnDAXHTj MGjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PSnE8Z6vmo+QjfFMOr8IzsEeysZ+b2m8XiyzgtxyjuU=; b=AFQ671+M1/GX0i8h19FP1l5E6qNXWrQf+YWpO3/4EW3wJqbvBP9lPPRlIpqWNy3bwO D50QOjEu8iePkmMY3dDbanK9m9FsDbmyJmtlKU+cGWptyBw2Z8XpwThmE5MHLGH2wmRU 44bavJPmrnDE/tNFYakVBIvJ/Q0wb7BwktWU9fbA4QRHOZ+QF0KTsW2svCAm2GSgRaAD 1sY3PHvBietqRqVUhf+hpH+hQmKHg/RyJtsK8aGjGIQMh8NCr12XBNAN5ZtTB5VmGc0r hWJdF63lRLdGmOi+B4lI8iiI0oL8GYK3ch6XVvb69drYugVVCGHlFe9ph5rO4tDYyG2u HjoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=TBEkdamh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i88si6936130edd.601.2020.10.09.10.15.59; Fri, 09 Oct 2020 10:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=TBEkdamh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387739AbgJIKhd (ORCPT + 99 others); Fri, 9 Oct 2020 06:37:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:34910 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbgJIKhd (ORCPT ); Fri, 9 Oct 2020 06:37:33 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602239851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PSnE8Z6vmo+QjfFMOr8IzsEeysZ+b2m8XiyzgtxyjuU=; b=TBEkdamhFsMR6aQi1th0/8dXZLXYyqk5xISPS7talJ6YDCQgCm/iVWjysiiw7bONwuX4IT gpaSi8QFNmbXeDNV5vq+E+NauqSVoU//Kjf9/qOHetw3vQr0tF0HyDgv9hNj8Fs9TDYrt9 B5EJ74pYx1zFCHSIQVIQnRK9ZCJToVc= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9C276AC2F; Fri, 9 Oct 2020 10:37:31 +0000 (UTC) Date: Fri, 9 Oct 2020 12:37:30 +0200 From: Michal Hocko To: Peter Zijlstra Cc: Thomas Gleixner , Frederic Weisbecker , LKML , Mel Gorman , Ingo Molnar , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org, Brian Cain , linux-hexagon@vger.kernel.org, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org Subject: Re: [RFC PATCH] kernel: allow to configure PREEMPT_NONE, PREEMPT_VOLUNTARY on kernel command line Message-ID: <20201009103730.GJ4967@dhcp22.suse.cz> References: <20201007120401.11200-1-mhocko@kernel.org> <20201009091218.GF4967@dhcp22.suse.cz> <20201009094245.GG2628@hirez.programming.kicks-ass.net> <20201009101044.GH4967@dhcp22.suse.cz> <20201009101431.GJ2628@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201009101431.GJ2628@hirez.programming.kicks-ass.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 09-10-20 12:14:31, Peter Zijlstra wrote: > On Fri, Oct 09, 2020 at 12:10:44PM +0200, Michal Hocko wrote: > > On Fri 09-10-20 11:42:45, Peter Zijlstra wrote: > > > On Fri, Oct 09, 2020 at 11:12:18AM +0200, Michal Hocko wrote: > > > > Is there any additional feedback? Should I split up the patch and repost > > > > for inclusion? > > > > > > Maybe remove PREEMPT_NONE after that? Since that's then equivalent to > > > building with VOLUNTARY and booting with preempt=none. > > > > So do you mean that I should post an additional patch which does this on > > top? With a justification that there is one option less to chose from? > > Exactly! It seems we have to get rid of CONFIG_NO_PREEMPT first $ git grep ARCH_NO_PREEMPT arch/Kconfig:config ARCH_NO_PREEMPT arch/alpha/Kconfig: select ARCH_NO_PREEMPT arch/hexagon/Kconfig: select ARCH_NO_PREEMPT arch/m68k/Kconfig: select ARCH_NO_PREEMPT if !COLDFIRE arch/um/Kconfig: select ARCH_NO_PREEMPT kernel/Kconfig.preempt: depends on !ARCH_NO_PREEMPT kernel/Kconfig.preempt: depends on !ARCH_NO_PREEMPT lib/Kconfig.debug: select PREEMPT_COUNT if !ARCH_NO_PREEMPT lib/Kconfig.debug: depends on !ARCH_NO_PREEMPT Is there anybody working on that. Is this even possible? I can see it has been added by 87a4c375995e ("kconfig: include kernel/Kconfig.preempt from init/Kconfig") but this looks more like a mechanical change and it has defined ARCH_NO_PREEMPT all arches which haven't included Kconfig.preempt. But is there any reason why those cannot support preemption for some reason? Cc respective maintainer (the email thread starts http://lkml.kernel.org/r/20201007120401.11200-1-mhocko@kernel.org -- Michal Hocko SUSE Labs