Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1602093760.git.yuleixzhang@tencent.com> <c53436d969cd70fd67b3eb8e02b75e138c364e91.1602093760.git.yuleixzhang@tencent.com>
 <2babfe21-beb8-762b-8ede-15f3467ca841@infradead.org>
In-Reply-To: <2babfe21-beb8-762b-8ede-15f3467ca841@infradead.org>
From:   yulei zhang <yulei.kernel@gmail.com>
Date:   Fri, 9 Oct 2020 19:49:01 +0800
Message-ID: <CACZOiM2goO0hhHdnYNkaSNiO2bfL+xwWY=RbVytXuhO+s1D7-g@mail.gmail.com>
Subject: Re: [PATCH 08/35] dmem: show some statistic in debugfs
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     akpm@linux-foundation.org, naoya.horiguchi@nec.com,
        viro@zeniv.linux.org.uk, Paolo Bonzini <pbonzini@redhat.com>,
        linux-fsdevel@vger.kernel.org, kvm <kvm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
        Wanpeng Li <kernellwp@gmail.com>,
        Haiwei Li <lihaiwei.kernel@gmail.com>,
        Yulei Zhang <yuleixzhang@tencent.com>,
        Xiao Guangrong <gloryxiao@tencent.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks, Randy. I will follow the instructions to modify the patches.

On Fri, Oct 9, 2020 at 4:23 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 10/8/20 12:53 AM, yulei.kernel@gmail.com wrote:
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index e1995da11cea..8a67c8933a42 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -235,6 +235,15 @@ config DMEM
> >         Allow reservation of memory which could be dedicated usage of dmem.
> >         It's the basics of dmemfs.
> >
> > +config DMEM_DEBUG_FS
> > +     bool "Enable debug information for direct memory"
> > +     depends on DMEM && DEBUG_FS
> > +     def_bool n
>
> Drop the def_bool line. 'n' is the default anyway and the symbol is
> already of type bool from 2 lines above.
>
> > +     help
> > +       This option enables showing various statistics of direct memory
> > +       in debugfs filesystem.
> > +
> > +#
>
>
> --
> ~Randy
>