Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for
 allocation in RING mode
To:     Nishanth Menon <nm@ti.com>
CC:     <t-kristo@ti.com>, <ssantosh@kernel.org>, <lokeshvutla@ti.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <grygorii.strashko@ti.com>
References: <20201008115224.1591-1-peter.ujfalusi@ti.com>
 <20201008115224.1591-11-peter.ujfalusi@ti.com>
 <20201009030204.3i3d6azsmfekl5qx@whole>
 <6d8f5331-251d-5409-4a1c-e3e42d340071@ti.com>
 <20201009115946.fl4lvkg5yk7f43pz@calculus>
From:   Peter Ujfalusi <peter.ujfalusi@ti.com>
Message-ID: <016056c8-ce56-6d28-1915-46451476fbba@ti.com>
Date:   Fri, 9 Oct 2020 15:10:36 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201009115946.fl4lvkg5yk7f43pz@calculus>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 09/10/2020 14.59, Nishanth Menon wrote:
> On 10:43-20201009, Peter Ujfalusi wrote:
>> Nishanth,
>>
>> On 09/10/2020 6.02, Nishanth Menon wrote:
>>> On 14:52-20201008, Peter Ujfalusi wrote:
>>>> -	ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev,
>>>> +	ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
>>>>  					ring->size * (4 << ring->elm_size),
>>>>  					&ring->ring_mem_dma, GFP_KERNEL);
>>>
>>> Any chance of getting a cleanup of the file for 5.11? I know this series
>>> has'nt introduced this warning or set of warnings, but I am starting to
>>> get concerned that we are carrying over too much of a debt now?
>>>
>>> https://pastebin.ubuntu.com/p/tT2kPDsCWD/
>>
>> Right, you know that git blame points the finger at you on ti_sci.c errors?
>>
>> Never the less, I have run the tool locally on my linux-next-wip with
>> these patches:
>> https://pastebin.ubuntu.com/p/myJwjvKYw8/
>>
>> and I don't see the noise you see.
> 
> 
> Hmm.. Looks like gcc9/10 make W=2 does generate those warnings with
> container_of .. I will investigate it later today.. just checking to see
> if it is just me seeing this..

It looks that way. W=2 is a kind of noisy if you throw it at a random
file, like:
make kernel/exec_domain.o W=2

> Yes, I introduced the container_of() usage, which is pretty standard
> usage in other subsystems as well, but lots of checks have gotten
> stricter and catches new issues since I introduced things in 2016..
> Time to get the new issues (if valid) fixed up.
> 
>>
>>> Checkpatch does point this:
>>>
>>> --- /tmp/kernel-patch-verify.25812/ptest_check-start	2020-10-08
>>> 19:33:31.025898581 +0000
>>> +++ /tmp/kernel-patch-verify.25812/ptest_check-end	2020-10-08
>>> 19:33:31.593893830 +0000
>>> @@ -0,0 +1,6 @@
>>> +CHECK: Alignment should match open parenthesis
>>> +#84: FILE: drivers/soc/ti/k3-ringacc.c:657:
>>> ++	ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev,
>>> + 					ring->size * (4 << ring->elm_size),
>>
>> Yes, that's correct. Readability VS very long lines
> 
> 
> checkpatch limit in linux kernel is now 100 chars (I know, it is
> hard to update .vimrc etc.. to the new norm..)but, anyways.. will
> be good not to see such warnings esp when you are touching the same
> lines.

Right, I can send v3 on Monday after a bit of re-adjustment of my editors ;)

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki