Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 9 Oct 2020 14:21:10 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Nicolin Chen <nicoleotsuka@gmail.com>
Cc:     krzk@kernel.org, robh+dt@kernel.org, jonathanh@nvidia.com,
        linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: memory: tegra: Add missing swgroups
Message-ID: <20201009122110.GD458338@ulmo>
References: <20201008003746.25659-1-nicoleotsuka@gmail.com>
 <20201008003746.25659-5-nicoleotsuka@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="k4f25fnPtRuIRUb3"
Content-Disposition: inline
In-Reply-To: <20201008003746.25659-5-nicoleotsuka@gmail.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--k4f25fnPtRuIRUb3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 07, 2020 at 05:37:45PM -0700, Nicolin Chen wrote:
> According to Tegra X1 TRM, there are missing swgroups in the
> tegra210_swgroups list. So this patch adds them in bindings.
>=20
> Note that the TEGRA_SWGROUP_GPU (in list) should be actually
> TEGRA_SWGROUP_GPUB (in TRM), yet TEGRA_SWGROUP_GPU (in TRM)
> is not being used -- only TEGRA_SWGROUP_GPUB (in TRM) is. So
> this patch does not add TEGRA_SWGROUP_GPU (in TRM) and keeps
> TEGRA_SWGROUP_GPU (in list) as it is.
>=20
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
>  include/dt-bindings/memory/tegra210-mc.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/include/dt-bindings/memory/tegra210-mc.h b/include/dt-bindin=
gs/memory/tegra210-mc.h
> index c226cba9e077..f9fcb18a6d9b 100644
> --- a/include/dt-bindings/memory/tegra210-mc.h
> +++ b/include/dt-bindings/memory/tegra210-mc.h
> @@ -33,6 +33,16 @@
>  #define TEGRA_SWGROUP_AXIAP	28
>  #define TEGRA_SWGROUP_ETR	29
>  #define TEGRA_SWGROUP_TSECB	30
> +#define TEGRA_SWGROUP_NV	31
> +#define TEGRA_SWGROUP_NV2	32
> +#define TEGRA_SWGROUP_PPCS1	33
> +#define TEGRA_SWGROUP_DC1	34
> +#define TEGRA_SWGROUP_PPCS2	35
> +#define TEGRA_SWGROUP_HC1	36
> +#define TEGRA_SWGROUP_SE1	37
> +#define TEGRA_SWGROUP_TSEC1	38
> +#define TEGRA_SWGROUP_TSECB1	39
> +#define TEGRA_SWGROUP_NVDEC1	40

I'm not sure this is right. The existing list is based on "Table 4:
Client to Software Name Mapping" from page 28 of the Tegra X1 TRM, and
none of these new swgroups seem to be present in that table.

Where exactly did you get those from?

Thierry

--k4f25fnPtRuIRUb3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+AVbYACgkQ3SOs138+
s6EjYw//d7rFLljg4uUz0GAYrWkU+KA1cHfZKLDjjJMNLRm6osUpTfew22WmLk5r
UupPbHAWPLRE6JEmRvd+YZo9woJR6PENh90tv05ZeyzT17OyqEhIcdwF6tvO+ToQ
4k1uvcuG2PIC1Ea7a9Q+jpi2H4g60bocm1StHVN0WCj5HzkmIXlK8rlgA7TkXNGC
eNvIYHq7orAhlk2OMgTzloYk0FcoJgykE3HuJhXbL4k5kO2c65F5Nf07TUyklK3y
2S2pZcGa7Qs1ztKWB8gHrhai9o6er4v+l2KGN/XNeyaDEzOIMqmfDxbSSyQPnTBL
IKHvWLLsDijohAT2FJpJkOOl8yDKDWD8Poi9S81JBEIhQzzWavy7X9vY4kfJqRhc
C2bUVvLswzKbiST2zSGuR7g38yqdW3JPa7yiKBjCIca+MYo0N2DZ+lvFoXvBWvOC
p6T5uVFBd7qhz/jWfcDD3n2hCcFEIXaljoLPNTEU3OhaoAymwPpgZFQuKlZrHuOK
/U1SkTGphPxLNf29TJiCeCfPUHmFCOY7QpJCcDeQ+gyB9dfXf9TZqwxSJE5341uo
PP2P86/Kiv/f/x0AnHFkDs7A41CgDEVX87y3x6lzCrUGHJOZH4VK21urVt1HwzVD
jrkTX4VOKj825TFTgY9ck/vxiuk/YkKlfReKqlzbbiTVxlvAkK0=
=C4t1
-----END PGP SIGNATURE-----

--k4f25fnPtRuIRUb3--