Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp2253583pxu; Fri, 9 Oct 2020 11:44:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiJQ3qZTSGGX/eOzd1eeyskgl87l9NUZp0V0WN3Oi04eoPBE6pkA9AZAg1inKQfD20oLkF X-Received: by 2002:a17:906:a101:: with SMTP id t1mr15262449ejy.203.1602269044086; Fri, 09 Oct 2020 11:44:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602269044; cv=none; d=google.com; s=arc-20160816; b=g19BEjyJ99MtKB9oTs8c+WbXWuDBV6CIgDPwgf4FOitO7fYxbmmnjGKeKV/Z+n1/f8 6q0Fbtid38HIwI0O3nrDnNgZ6HOCAYcIadSLnyYRZoy/D3aBfccGNtQ9EYWSAIIMNzSs 0TXOJyaAcbRUVic+VtA7ExMxoMeg9snNXsCJP7tFQ4mq5QlNkrKtO8raW9mPOJHWhjct 1WOYpHz/VJKqgsji4LBFZ4KWyZXGwAAotT5QtzrYYKnoHlvnxFU9Gp2UJc/wJR2j0Obe 9pMJtSmTMdVqiiG7T8ew4DzAoEmPp7bC+3N32HZNumSfd0Te3B+Vr8by92qk53v20hu5 +cpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=CcKsaaPzQT2ESj6YOvwBkh06P5IZh1MGDwlgLgs4VHo=; b=zP97o701uVL7vPpoHIhCi6qA7aey53SwbH6Y4u7FJE9l1ftbzUEbqRSRQ7vXo+3GpH mG481UfdqCZGYLS+GKy63G8PbBcZ2bwIXeHz2dHkyfYv4hYGFbUyJ7q+aUtzMpzyPBjM sJP7XHeBJSo9GQAdEZlx7ZJJ/XO4ReUAIUHOoRQ+JCytQOXL1KJ8EA4dgiXz6vum7pEZ 3ng61wfCGQ/cu+AHvcC2Tz8/yYqassMGcoZidsGeITw/pxfvHLLJOfEqT1lFbvVSCTMR X42P53Ncd3yXvl2P6cO77GO7EXtTdhnsLrlkxncQLkKYPFdk/1b82B7KXYuf/vEaCLu0 TFRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=NlLNJz0g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c14si6672838edj.174.2020.10.09.11.43.39; Fri, 09 Oct 2020 11:44:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=NlLNJz0g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388639AbgJIOSN (ORCPT + 99 others); Fri, 9 Oct 2020 10:18:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731698AbgJIOSI (ORCPT ); Fri, 9 Oct 2020 10:18:08 -0400 Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4EE9C0613D2 for ; Fri, 9 Oct 2020 07:18:06 -0700 (PDT) Received: by mail-qt1-x841.google.com with SMTP id r8so7984091qtp.13 for ; Fri, 09 Oct 2020 07:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CcKsaaPzQT2ESj6YOvwBkh06P5IZh1MGDwlgLgs4VHo=; b=NlLNJz0gReMZ2olYoTwOI71Q3J7hZ4eCjDSLwfxrDsINskB/uRN0RJ63/6e4mp7rWK 8HBBtYSi0tq6rQFBsNjlT8Imwpm8kDcN4jK2nSy7e062CLRT5RQCSFjHf1lN8ImYUGqc /vhv7tZjTIgwahWg6NDlOfjzYJ70RBtTYFaUtayjCmBbBlk6KxW8RzL4UWdAG77v2I9N A7UYx+wU+9EnXtsWlWiz3jQTPpdXvIdYWAVVCCCHPiVwb88OgPGRxAtC9APpf83BXrog jD06zR6/j/9ASrwFeC4hcqIdoEkQl6E5WRGzyO2rSgnCpr/6ATUZ0Ujgycjt3F5z1/Cd Sd+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CcKsaaPzQT2ESj6YOvwBkh06P5IZh1MGDwlgLgs4VHo=; b=scqPI9Z3urFQEnNVKNaWOZEXJXnf7VazGU/9PbvgYdJHfrd/rfapqch9cLbdG+LyCL Hp0rxC/TfzjNQqimUAP5uWuiNeoae5JGkxOxMp2PQcg/TjLbDqnJbrSX4cRCMvpclXmE 3bOgByUosF4tPUAH3HqNwudZiEHngid7QvkSTqTsFBXm1vFoe07qJBq/WFlwMuAsJ4so 31VaSNOGUblzP4Uluy+7i83ZbvzyVFTO7JEw8ADEttmBAOjM9hhZxYXZa2f7ZtRUXMMK 2hvgbaLZm3VQwcC58W/nwl4c94yxF12gMa9oPxVCNRzOLAGAmgH1hGsRx6uHjPzNUkeE FNMA== X-Gm-Message-State: AOAM5321JfyYUh33NND6dQF4tnb45ZM2oWQJwCEsUnWEs2v/jmFf25cw Nn2jgLEXshPsfwMYBgXpaoXopw== X-Received: by 2002:ac8:5d04:: with SMTP id f4mr13754639qtx.290.1602253085840; Fri, 09 Oct 2020 07:18:05 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a8:11e8::107d? ([2620:10d:c091:480::1:f1f8]) by smtp.gmail.com with ESMTPSA id f3sm6216160qtp.57.2020.10.09.07.18.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Oct 2020 07:18:03 -0700 (PDT) Subject: Re: [PATCH 5/7] btrfs: Promote to unsigned long long before shifting To: "Matthew Wilcox (Oracle)" , linux-fsdevel@vger.kernel.org Cc: ericvh@gmail.com, lucho@ionkov.net, viro@zeniv.linux.org.uk, jlayton@kernel.org, idryomov@gmail.com, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org, clm@fb.com, dsterba@suse.com, stable@vger.kernel.org References: <20201004180428.14494-1-willy@infradead.org> <20201004180428.14494-6-willy@infradead.org> From: Josef Bacik Message-ID: Date: Fri, 9 Oct 2020 10:18:01 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201004180428.14494-6-willy@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/20 2:04 PM, Matthew Wilcox (Oracle) wrote: > On 32-bit systems, this shift will overflow for files larger than 4GB. > > Cc: stable@vger.kernel.org > Fixes: df480633b891 ("btrfs: extent-tree: Switch to new delalloc space reserve and release") > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Josef Bacik Thanks, Josef