Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
Authentication-Results-Original: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
Date:   Fri, 9 Oct 2020 14:26:13 +0100
From:   Brian Starkey <brian.starkey@arm.com>
To:     Matteo Franchin <Matteo.Franchin@arm.com>
Cc:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "mripard@kernel.org" <mripard@kernel.org>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        Liviu Dudau <Liviu.Dudau@arm.com>, joe@perches.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>
Subject: Re: [PATCH v2] drm/fourcc: Add AXBXGXRX106106106106 format
Message-ID: <20201009132613.3zvbn76guoxvahdw@DESKTOP-E1NTVVP.localdomain>
References: <20201008143350.5306-1-matteo.franchin@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201008143350.5306-1-matteo.franchin@arm.com>
User-Agent: NeoMutt/20180716-849-147d51-dirty
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from DESKTOP-E1NTVVP.localdomain (217.140.99.251) by LO2P265CA0330.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23 via Frontend Transport; Fri, 9 Oct 2020 13:26:14 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 47019ed7-69c4-49d3-fc86-08d86c56eca1
X-MS-TrafficTypeDiagnostic: HE1PR08MB2892:|VI1PR0801MB1759:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0801MB175916D88D715D43B8D5148AF0080@VI1PR0801MB1759.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
NoDisclaimer: true
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: JQ9aE3uLt7oSpqxKizl1EVd8d3Ge3AjJa2JtmdcuhCzvsVXxZUKlJIOHoIcUYHFkTkXXRhiZjVFwr9xRgj+gh14r9hLSZUNcYV9jR+FUIKoNCK7Hd9KJNdmILVnF7fllkPqFDJQYhOO7YakmVgqgvJvknE7RM4XFeZ4O0sYC6+CevHdiTWjZojXK8+8son4gS/F2ykJs7O8yDEsai7F0s6lOzLzGvoIv+BLsmiyK2n+9ZxfZjLl3zO9NrAGcR68LiAWD+HdZBGNLAZiX72yFZpGunnVXVpd1aQblz0/ckRmBhzwHDnzOOOCMuILFY2trYEvr5XFcAic3r5lGQ4EcAg==
X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1PR08MB2890.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(376002)(136003)(346002)(396003)(39850400004)(478600001)(956004)(2906002)(66946007)(44832011)(8676002)(7696005)(8936002)(54906003)(5660300002)(316002)(6862004)(4326008)(1076003)(52116002)(16526019)(9686003)(6506007)(66556008)(66476007)(186003)(86362001)(55016002)(26005)(6636002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: aFfLGuHmA4FTngVipGfqZVDCuGoJ5plrFKJnsM66Xi+/CpgokMiATMScE/GJDepb2D7B+OaxAuC1QFyQG4HXtRziqmLATLeLtyGZmU6nO/XEBHCve+81BtygEcWgM4Us3I3wesekJo1ZXlQ/t8O+JF+Mf/qPpO3uXCBYl5tiXzjeQjMG93THfaUXciKb5Eiwe7P0cyQNtaMlduZaxfoihzY7iIZurwbNFDX6VqBZPxIjt1qv4SJitg5KbGULITJQuIlvOmzdFA3XJsjgc6BknGoL55DNLh+xmP2Ux8EikkgnerS0vzomz/p/Juhv+v7OvpiS7rOSEmYPNU1dI76bQBG6tvqqpafu62znLcBikFaA+izDlhqwMV/340Q1WztL+OwQCoj0UyKfcaj6ToKwrU/ZNJv5U6idduEaoB+1Wrgg2u4YWn4iZD8HpMHo5JCUDE5m2XgwRwKUATFGqr+mX+67h106kIeVSn74TcWlAMrJCYfNijVfCRRacwt764lNNnQZKia8EziogWX5O4s9imPJrszxJjZyc+bmlX3s9MVDWvgdVjqmkPjFricnMlUEA6sIg7O4C8bJH/y0ujg+119REEi89mdJ/WWtfNy6HgqZ6E2XGqrx5zf80IfAZCtiNz2qFwHht7lupaLCke3rVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2892
Original-Authentication-Results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs: b12c55ea-b549-43d8-419f-08d86c56e5e4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: y8AmRBXHi6vztsDk5LSdcanM2+MKgqN6gV4Nn3RszlU1cHehEjxubDDahP3ERpeLHUCompauHTcAjvNMsAAd/wynWvuAFMRm+A17NAwpWfqY340q/Wkoaw6qNdlKi4fucLgCri/SajZ5yJq555hwJI85cQ0euxeSqeW6S3Yogj4X3k9nxDrUb5M0h1Vqot9GHQvotAFYYMxRxv7ytR6edZ99Tjb9Ljc7Bcy67kmfdA+PCehgHjbePcCRKvgFiwCs0aDlNmLuIQp3Jo0XzHfu8g76Wsya7L+uYviDZZSgwrG0Z9SzPHFGkkKlM6GJNOqerhsXCX5yq3zYvDN77xXcRFS7qGj6ms1s/z4n9huENhtMdnhTPVSoWLhKjWLiBH85IrZ4nsnBI5yLsgW66ePoFw==
X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(376002)(396003)(136003)(346002)(46966005)(81166007)(316002)(5660300002)(47076004)(26005)(54906003)(82740400003)(186003)(8676002)(7696005)(336012)(6506007)(4326008)(82310400003)(44832011)(6862004)(2906002)(478600001)(16526019)(356005)(55016002)(70586007)(956004)(70206006)(1076003)(9686003)(8936002)(6636002)(86362001);DIR:OUT;SFP:1101;
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2020 13:26:26.4881
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 47019ed7-69c4-49d3-fc86-08d86c56eca1
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1759
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Matteo, +Joe to Cc

On Thu, Oct 08, 2020 at 03:33:50PM +0100, Matteo Franchin wrote:
> Add ABGR format with 10-bit components packed in 64-bit per pixel.
> This format can be used to handle
> VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 on little-endian
> architectures.
> 
> Signed-off-by: Matteo Franchin <matteo.franchin@arm.com>
> ---
>  drivers/gpu/drm/drm_fourcc.c  | 1 +
>  include/uapi/drm/drm_fourcc.h | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
> index 722c7ebe4e88..03262472059c 100644
> --- a/drivers/gpu/drm/drm_fourcc.c
> +++ b/drivers/gpu/drm/drm_fourcc.c
> @@ -202,6 +202,7 @@ const struct drm_format_info *__drm_format_info(u32 format)
>  		{ .format = DRM_FORMAT_XBGR16161616F,	.depth = 0,  .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1 },
>  		{ .format = DRM_FORMAT_ARGB16161616F,	.depth = 0,  .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
>  		{ .format = DRM_FORMAT_ABGR16161616F,	.depth = 0,  .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
> +		{ .format = DRM_FORMAT_AXBXGXRX106106106106, .depth = 0, .num_planes = 1, .cpp = { 8, 0, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },

I'm OK with it formatted like this tbh. The YUV formats at the bottom
already mess up the formatting of the table as a whole.

If Joe feels strongly about having it split, I don't think that should
hurt grep-ability much for the common cases (grep for format name, or
grep for format parameters). So either way you can add:

Reviewed-by: Brian Starkey <brian.starkey@arm.com>

Thanks!
-Brian

>  		{ .format = DRM_FORMAT_RGB888_A8,	.depth = 32, .num_planes = 2, .cpp = { 3, 1, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
>  		{ .format = DRM_FORMAT_BGR888_A8,	.depth = 32, .num_planes = 2, .cpp = { 3, 1, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
>  		{ .format = DRM_FORMAT_XRGB8888_A8,	.depth = 32, .num_planes = 2, .cpp = { 4, 1, 0 }, .hsub = 1, .vsub = 1, .has_alpha = true },
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 82f327801267..9374d9558493 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -155,6 +155,12 @@ extern "C" {
>  #define DRM_FORMAT_ARGB16161616F fourcc_code('A', 'R', '4', 'H') /* [63:0] A:R:G:B 16:16:16:16 little endian */
>  #define DRM_FORMAT_ABGR16161616F fourcc_code('A', 'B', '4', 'H') /* [63:0] A:B:G:R 16:16:16:16 little endian */
>  
> +/*
> + * RGBA format with 10-bit components packed in 64-bit per pixel, with 6 bits
> + * of unused padding per component:
> + */
> +#define DRM_FORMAT_AXBXGXRX106106106106 fourcc_code('A', 'B', '1', '0') /* [63:0] A:x:B:x:G:x:R:x 10:6:10:6:10:6:10:6 little endian */
> +
>  /* packed YCbCr */
>  #define DRM_FORMAT_YUYV		fourcc_code('Y', 'U', 'Y', 'V') /* [31:0] Cr0:Y1:Cb0:Y0 8:8:8:8 little endian */
>  #define DRM_FORMAT_YVYU		fourcc_code('Y', 'V', 'Y', 'U') /* [31:0] Cb0:Y1:Cr0:Y0 8:8:8:8 little endian */
> -- 
> 2.17.1
>