Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp2291416pxu; Fri, 9 Oct 2020 12:48:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxI7IKEAwDN+W8jwH1Bl9fJEWQu2fXjcMuXjXzj4GFhGtrkNB690YfI0M9c5RPVMeFNYXlj X-Received: by 2002:aa7:c3ca:: with SMTP id l10mr942666edr.72.1602272920437; Fri, 09 Oct 2020 12:48:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602272920; cv=none; d=google.com; s=arc-20160816; b=doIP/WZgGlNnfBpSl7e6956ArVD69uPZqvx0/rvUuU+9JYN1OiIU3TlCYg+PFUZ1Oz k0t7McFDYNLnvNl0rFd7LYN9YhvInwGJ8DutN0jRB4w7vWqN3AHtXH7VYpHtK0WVlSxI Sr4xeUfATcjsHb1TR7r4eh00R4GzO9ghnHivilUP6MmMj97wn38GNy67P15eMndxrUNp NRNy5LolIkaiTi7F5NbGgOy4dD6TpW8DuhzkJpAMszi+/REBv2C3masBLISfNGWHSr6T qn+HM6ExD76bEAVEpFLNv9YZSuxDOWMvQF+/ygm6LU4jPmcu5yAnjtPuzBnuWJ2WOnBb lOtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=3bsTtjX+cDplcCHwdryPuddNIS5y8t2+4/IvG5FFzSM=; b=KqQvaO0ktvB2dgId0lulzLTPk2fVk1XKY95EImdeTRY/zOBxXolJKayPnboKdo2szi O68fjKsVA3X7zIGNH3BQ5F1QF3aJH+Yg0edF0tYfja63XQG/Og+8giYaBBxCUTuc/d2f gKjvzl0KklCiwYdTGa2ly3OL5O6UgC8iAXKlKfdpcuMaVeD2EiV0esLaggsZ2RHQLc9y SYIXFiGtTqMZF4TJmJGvnCehYAuiqFQs9WGMW0Uqmvs59rq0xMZIAqn/fWk8L2GpsMzl VwufnZMRAsj4stbr4UfWEvUmzR5G5hmiNwaplyzZrsmYLP2yID2pdz1ytk7/2wO7a94h RtYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i23si6640728ejz.318.2020.10.09.12.48.17; Fri, 09 Oct 2020 12:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388860AbgJIOlF (ORCPT + 99 others); Fri, 9 Oct 2020 10:41:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388707AbgJIOlE (ORCPT ); Fri, 9 Oct 2020 10:41:04 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 827F0C0613D5; Fri, 9 Oct 2020 07:41:04 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kQtZs-002KHD-Ot; Fri, 09 Oct 2020 16:41:01 +0200 From: Benjamin Berg To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman , Guenter Roeck , linux-kernel@vger.kernel.org, Benjamin Berg , Hans de Goede , Heikki Krogerus Subject: [PATCH 1/2] usb: typec: ucsi: acpi: Always decode connector change information Date: Fri, 9 Oct 2020 16:40:46 +0200 Message-Id: <20201009144047.505957-2-benjamin@sipsolutions.net> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201009144047.505957-1-benjamin@sipsolutions.net> References: <20201009144047.505957-1-benjamin@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Benjamin Berg Normal commands may be reporting that a connector has changed. Always call the usci_connector_change handler and let it take care of scheduling the work when needed. Doing this makes the ACPI code path identical to the CCG one. Cc: Hans de Goede Cc: Heikki Krogerus Signed-off-by: Benjamin Berg --- drivers/usb/typec/ucsi/ucsi_acpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c index fbfe8f5933af..04976435ad73 100644 --- a/drivers/usb/typec/ucsi/ucsi_acpi.c +++ b/drivers/usb/typec/ucsi/ucsi_acpi.c @@ -103,11 +103,12 @@ static void ucsi_acpi_notify(acpi_handle handle, u32 event, void *data) if (ret) return; + if (UCSI_CCI_CONNECTOR(cci)) + ucsi_connector_change(ua->ucsi, UCSI_CCI_CONNECTOR(cci)); + if (test_bit(COMMAND_PENDING, &ua->flags) && cci & (UCSI_CCI_ACK_COMPLETE | UCSI_CCI_COMMAND_COMPLETE)) complete(&ua->complete); - else if (UCSI_CCI_CONNECTOR(cci)) - ucsi_connector_change(ua->ucsi, UCSI_CCI_CONNECTOR(cci)); } static int ucsi_acpi_probe(struct platform_device *pdev) -- 2.26.2