Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ata: ahci: mvebu: Make SATA PHY optional for Armada 3720
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Gregory CLEMENT <gregory.clement@bootlin.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Grzegorz Jaszczyk <jaz@semihalf.com>,
        Andre Heider <a.heider@gmail.com>,
        Tomasz Maciej Nowak <tmn505@gmail.com>
Cc:     linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201009084244.29156-1-pali@kernel.org>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <7e60bd4f-46bf-cc13-0705-0431adc699c7@kernel.dk>
Date:   Fri, 9 Oct 2020 12:48:08 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201009084244.29156-1-pali@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 10/9/20 2:42 AM, Pali Rohár wrote:
> Older ATF does not provide SMC call for SATA phy power on functionality and
> therefore initialization of ahci_mvebu is failing when older version of ATF
> is using. In this case phy_power_on() function returns -EOPNOTSUPP.
> 
> This patch adds a new hflag AHCI_HFLAG_IGN_NOTSUPP_POWER_ON which cause
> that ahci_platform_enable_phys() would ignore -EOPNOTSUPP errors from
> phy_power_on() call.
> 
> It fixes initialization of ahci_mvebu on Espressobin boards where is older
> Marvell's Arm Trusted Firmware without SMC call for SATA phy power.
> 
> This is regression introduced in commit 8e18c8e58da64 ("arm64: dts: marvell:
> armada-3720-espressobin: declare SATA PHY property") where SATA phy was
> defined and therefore ahci_platform_enable_phys() on Espressobin started
> failing.

Applied, thanks.

-- 
Jens Axboe