Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp2548453pxu; Fri, 9 Oct 2020 22:36:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwE/HM+qvBEvsYIEikEOhAY6ZkNlZy+35erz7QmtX7oyZTVcjjIdqO1eqUwcvNgaWdnqJlO X-Received: by 2002:a17:906:8295:: with SMTP id h21mr9703162ejx.278.1602308177063; Fri, 09 Oct 2020 22:36:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602308177; cv=none; d=google.com; s=arc-20160816; b=Elj3pcG0bhH3UDyzX4zfxM/kNMa8jEhujEtupSv65QUHaGla85vFSTbYYJ26lzvQqJ sp20Dn2h+byjXdiF348Afp5O6y1cutXPp8EHHyT8xl2qhS3OMj4AYt0VLYwlGPZ9bVqe OBzQ9n7Dt8NgZC/4Rqeo5tVcnwvbK4t8bNHRRT16E8ST8KSQd6T6TXzy1Q78o5hDfDco 39pohHCYvRuECPk9B/OlD4cfiATh0lk49Z2jZPIBF44QiecA7q/Gx74EayClTXOrNyQl VWZIQjcApi7/ZLnIuoQyZft7H2LAqo5/Q8j4SsBUIl+X72gx9cicECf1aPYCwM+smDCE PL5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/mYTOv/21wwiwc815ckdC6WFh1buru+KIL7Ummf28YE=; b=ZYzFP3VyC5Hx707Sgeys2rvYsydbLlYdisLlhMD46wzLofA47yqRfJZbcDpSeBMrNV FtBV08qn8QOGbAh2PZvpCFhMxkAqmOz2rUfonZ66qrqvTxaxH9Js++/7JFDxG2rEnLC+ 8JaAdZD+y2sP6WyIdCVrtklSL/ac0+dHLtxwCnwm6EdZZBcYQfAm6jgZiXarQe6atTfZ OGE6u47+bisI98dCaFd0TUnqa54WRKHJ5NlsTGbHhJO9XFWY1A33K8J4xW1hqi1LLVjA KM+3hcMXRvGEYvJS0LjHk/JqGwv+zXXb1eVm+5pczyBSDtpIgR7go/81kGQZj5M75ZDE mZsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=Sqt8Kxsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u8si7482257edy.179.2020.10.09.22.35.53; Fri, 09 Oct 2020 22:36:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=Sqt8Kxsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390901AbgJIWEX (ORCPT + 99 others); Fri, 9 Oct 2020 18:04:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:58932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390754AbgJIWEX (ORCPT ); Fri, 9 Oct 2020 18:04:23 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21CE12225B; Fri, 9 Oct 2020 22:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602281061; bh=oITbHTmVfb1q7fGqfRr1elEf4VBd3T6psegkhAry820=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sqt8KxsmiMnGuR0FT3Y4aouz0n876VypJIivZK9FUCA4pSf8ob4uuB47fWSLQVpHe jX2gkLdcbNdzObqUeuxaPZ9R6zqIm9NdO9kF4Eo6wFiR916yXnFU9ACe7jRwX0wz2u mpcdILw6zl4jSuUJsqNpaZKW94F3xjT8wN+ua4cY= Date: Fri, 9 Oct 2020 15:04:20 -0700 From: Andrew Morton To: =?ISO-8859-1?Q? "Christian_K=F6nig" ?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, daniel@ffwll.ch, sumit.semwal@linaro.org, willy@infradead.org, jhubbard@nvidia.com, jgg@ziepe.ca, Miaohe Lin Subject: Re: [PATCH 1/6] mm: mmap: fix fput in error path Message-Id: <20201009150420.450833e3830b9d39a2385dd9@linux-foundation.org> In-Reply-To: <20201009150342.1979-1-christian.koenig@amd.com> References: <20201009150342.1979-1-christian.koenig@amd.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Oct 2020 17:03:37 +0200 "Christian K=F6nig" wrote: > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > adds a workaround for a bug in mmap_region. >=20 > As the comment states ->mmap() callback can change > vma->vm_file and so we might call fput() on the wrong file. >=20 > Revert the workaround and proper fix this in mmap_region. >=20 Doesn't this patch series address the same thing as https://lkml.kernel.org/r/20200916090733.31427-1-linmiaohe@huawei.com?