Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3097124pxu; Sat, 10 Oct 2020 19:51:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVNV4T+1AUdXbnbTbtq3MJVujU4tip9KCw0uUwsHt5eyElkaFvCEwRJvujKit0YbmIMLva X-Received: by 2002:aa7:d948:: with SMTP id l8mr7293548eds.159.1602384709558; Sat, 10 Oct 2020 19:51:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602384709; cv=none; d=google.com; s=arc-20160816; b=GowEjX07hiZMztwlQ1MDVUHc38RB/8NtmlgJF4uQm9u9/ISIQME8S20L2RYtXx347s tGnHzh5WgZLW6vDw8ApCeD0ZmjdYLYviLpQvwcFfzJzZ7fwVxR5ZSfsa3brkz+M+yD44 q8ra0E2FzJ7qLlRYVZTOxaV0SfTdxopTfQl9WbhQnpCdXGIacc/LcStfM6UIegMF36r3 On2Dm1rh/GcPn0L/Xoh3Mb7nMh2UwGP5Hx1lieQ/tjNC6o7DqzFOA0afj5f14hDqEF/2 qGYuNYfgbws0VMlAdfeJF++Jp2pscEGLxDkJ3mhy7QnOWfPINmFFwoA2vHKiEIil3dHh 5DsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=s6G6YLhuQ8YhUBsYDzQjuCrO5rTHLw9HuFyhEDF1ae0=; b=YRI3TT01lZkOrj5zN7q/lB64xM6YZNtogpYDEYtKrFDNArF4hHkYNW3R2M5g44Euvq SDICmA0DfbGgGjK6uJ6gIAPybhgBAH233Y+suxnHSj5+t7MU8kEcCpQ2QWsnOlo+wpza eBfMJWOFq1+GWe+C3RvaB+7oTUu0XChxnDSLKx5zhEI3D/0oz4NgAESomztEgA7zi4jb LSMnF7f5GIa5WmVrvTCAWvR5hB80O7GBmMs9d1bcGjns6DY2ImAHZZSla7wegiH8O5Ra OEn71yJ1rz9kzGW/iINYP5znDceeSLpLG29c9o5h0U+qUvLYWXromof8SDOu98CgRLnV xuZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=hbzoONbN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hpe.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si10829749edi.587.2020.10.10.19.51.27; Sat, 10 Oct 2020 19:51:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=hbzoONbN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=hpe.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728928AbgJJATr (ORCPT + 99 others); Fri, 9 Oct 2020 20:19:47 -0400 Received: from mx0b-002e3701.pphosted.com ([148.163.143.35]:40080 "EHLO mx0b-002e3701.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728696AbgJJALH (ORCPT ); Fri, 9 Oct 2020 20:11:07 -0400 Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09A08t2l016461; Sat, 10 Oct 2020 00:09:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pps0720; bh=s6G6YLhuQ8YhUBsYDzQjuCrO5rTHLw9HuFyhEDF1ae0=; b=hbzoONbNgv1IfWMe6VwhKAE0f/2ph0f40vq57EpLpFdo5g8R4dhlpOhyDtAEwWOEoZQf JZhV968xKRM6+4agzUR/SWPyeUgkPH7y8HbPXWNDXV07rJd/LUBY6pCM90bB/sool4Ce eXmvO9V4CVVLjR3XigdbXkjHnq+SYwAgETA4XodIkYjtbpbyhwGVc0xzk+5jSsszyBBQ Xs1djC6tpA0nzT742LQtf6zHFhIKPKs5YEimzPtJb30J8zI/eWz8nD1EvuwB+uS41qpH Gu1TdO+7Oqd6Rw8wX+3yBlAmrvdKTcB+HfuxgrloAUfIoqpVthLXRJBG6uqSTBq89WMW 3w== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com with ESMTP id 342nqcdd02-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 10 Oct 2020 00:09:30 +0000 Received: from g9t2301.houston.hpecorp.net (g9t2301.houston.hpecorp.net [16.220.97.129]) by g9t5008.houston.hpe.com (Postfix) with ESMTP id 838F462; Sat, 10 Oct 2020 00:09:29 +0000 (UTC) Received: from sarge.linuxathome.me (unknown [16.29.167.198]) by g9t2301.houston.hpecorp.net (Postfix) with ESMTP id 8E03D4A; Sat, 10 Oct 2020 00:09:27 +0000 (UTC) From: Hedi Berriche To: Kuppuswamy Sathyanarayanan Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hedi Berriche , Russ Anderson , Bjorn Helgaas , Ashok Raj , Joerg Roedel , stable@kernel.org Subject: [PATCH v2 0/1] PCI/ERR: fix regression introduced by 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") Date: Sat, 10 Oct 2020 01:09:15 +0100 Message-Id: <20201010000916.2572432-1-hedi.berriche@hpe.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-10-09_14:2020-10-09,2020-10-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 phishscore=0 clxscore=1015 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 mlxlogscore=664 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010090182 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org - Changes since v1: * changed the commit message to clarify what broke post commit 6d2c89441571 * dropped the misnomer post_reset_status variable in favour of a more natural approach that relies on a boolean to keep track of the outcome of reset_link() After commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") pcie_do_recovery() no longer calls ->slot_reset() in the case of a successful reset which breaks error recovery by breaking driver (re)initialisation. Cc: Russ Anderson Cc: Kuppuswamy Sathyanarayanan Cc: Bjorn Helgaas Cc: Ashok Raj Cc: Joerg Roedel Cc: stable@kernel.org # v5.7+ --- Hedi Berriche (1): PCI/ERR: don't clobber status after reset_link() drivers/pci/pcie/err.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) -- 2.28.0