Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3282341pxu; Sun, 11 Oct 2020 04:11:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGNBBrSHzn4iyqt2nyh+EdiYvMdvgnUrXLYieSd/fKFbKo8aVqTRK/LbaD68GEdayx8y6k X-Received: by 2002:a17:906:b841:: with SMTP id ga1mr22862107ejb.29.1602414660337; Sun, 11 Oct 2020 04:11:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602414660; cv=none; d=google.com; s=arc-20160816; b=w872y39wCrLgmiGdi2GxmVyoIzXXJ1zycaWLhAPrjmLmg97/dhPdfYFX6B4zsKPUVg /vR7V08WJ8L/4x1VaEPAgySvpIo/1IVKDP14VMrvypxt+m/w6rbrS6gwnC1/YzQQO6v3 0KGc9uBPwrAqq+ZBxcRrdoBnVksaijD0IbebhZKW79HwfDi8/uRcSb3SJNv5BWKzJi7t b1bTY9laHT4r6nFfPJy3bUQDQ5htwfjSuXKrUjO/vT9GnQINpirfZZQVfdXfNwlBHbfe kdCT8RwpjXl0do3tb2cdKmSU6iQu9NOaHjDAa97a8RUFHquttfgjZA//5xFGWz3jVnrF EdfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2uBO7RNe7ovQrC9ot6U+qDqGA3X3zydULCvJNt5ipSU=; b=fRNCDOxf+j+InC+2sS8b2tpbWVnGvMo2tzEZR9TfWmUVUHotX56Y0yhGqmtc1X9JEb xpbKQhdNbp4fbRTQ8H7nn+olB+319AXyrK7HQkhsRRGYoEVvwVkzHWBQpptyBsLm8vyn NBByidquwmLnyc/0RkXLdvB+HxG9l6Ln4pTUnI3sYVT802OjOStQ5GlfkOsuYpF2gX1I dztxquGN4BCH9oI1xmr7BIUUO4UwJniQlOdNIaa7JyV87JoMuoMXDolU6zTN2HiB7Ew4 C7rQEQjMJkEZWDWF4b5xu6q1n1hInhvvNB+YsE2r+hB+IPyJqW5NhTjMjj3LLzPCgdIr 5niQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZgbF8bwi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm9si10602870edb.76.2020.10.11.04.10.36; Sun, 11 Oct 2020 04:11:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZgbF8bwi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733140AbgJJWne (ORCPT + 99 others); Sat, 10 Oct 2020 18:43:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:48682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731123AbgJJTCW (ORCPT ); Sat, 10 Oct 2020 15:02:22 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 112712242B; Sat, 10 Oct 2020 16:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602349041; bh=tvRSA9R+WFrxxVwgdjd4mNTVYdF+H8JAqH74nfC64co=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZgbF8bwi2UcwgQkisyGyNYTjjBlwqldV4vgAnD3Jv5bGIF2p9LtXEWQc1F+78JT0D xY4+fZfeFRbH0/40ELyQHlLcLjTNDdVRKOYQhEiTuNQ+liidwbYO0y4f7u9DpGQ5lN EVgZQalZesICskJ4Xb2cFQ0mX0R9DnjdXxYF+l3c= Date: Sat, 10 Oct 2020 17:57:14 +0100 From: Jonathan Cameron To: Gene Chen Cc: robh+dt@kernel.org, matthias.bgg@gmail.com, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH v6 0/3] iio: adc: mt6360: Add ADC driver for MT6360 Message-ID: <20201010175714.0fb968ab@archlinux> In-Reply-To: <1601542448-7433-1-git-send-email-gene.chen.richtek@gmail.com> References: <1601542448-7433-1-git-send-email-gene.chen.richtek@gmail.com> X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 1 Oct 2020 16:54:05 +0800 Gene Chen wrote: > This patch series add MT6360 ADC support contains driver, testing document > and binding document > > Gene Chen (2) > dt-bindings: iio: adc: add bindings doc for MT6360 ADC > Documentation: ABI: testing: mt6360: Add ADC sysfs guideline > iio: adc: mt6360: Add ADC driver for MT6360 Hi Gene This looks good to me. I'm just waiting now on some final reviews for the patch that adds the label attribute support. Once those are in I'll pick your driver up as well. If I seem to have lost it, feel free to poke me! Thanks, Jonathan > > Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360 | 78 ++ > Documentation/devicetree/bindings/iio/adc/mediatek,mt6360-adc.yaml | 34 > drivers/iio/adc/Kconfig | 11 > drivers/iio/adc/Makefile | 1 > drivers/iio/adc/mt6360-adc.c | 362 ++++++++++ > 5 files changed, 486 insertions(+) > > changelogs between v1 & v2 > - adc: use IIO_CHAN_INFO_PROCESSED only > - adc: use devm_iio_triggered_buffer_setup > - adc: use use s64 to record timestamp > > changelogs between v2 & v3 > - Rearrange include file order by alphabet > - Set line length constraint below 100 > - Add Document for testing adc sysfs node guideline > - Set compiler 64 bit aligned when handle iio timestamp > > changelogs between v3 & v4 > - Fix sysfs guideline description > - Replace iio channel processed by raw/scale/offset > - Add comment of read adc flow for special HW design > > changelogs between v4 & v5 > - Rename dt-bindings aligned to file name > - Aligned sysfs node name with driver and add VBUSDIVX description > - Add ADC channel sysfs node "*_labels" > > changelogs between v5 & v6 > - Memset aligned adc data > - Remove strong casting void pointer >