Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Ran Wang <ran.wang_1@nxp.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jun Li <jun.li@nxp.com>,
        "open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: host: fsl-mph-dr-of: check return of dma_set_mask()
Thread-Topic: [PATCH] usb: host: fsl-mph-dr-of: check return of dma_set_mask()
Thread-Index: AQHWnsxMafGOyChLpEqh4ZaQKTdKaqmRf+CA
Date:   Sat, 10 Oct 2020 23:40:55 +0000
Message-ID: <20201010234028.GA16433@b29397-desktop>
References: <20201010060308.33693-1-ran.wang_1@nxp.com>
In-Reply-To: <20201010060308.33693-1-ran.wang_1@nxp.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B7AD5C457915104989BE8079B8DAEF0E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe317c8-1728-4a2b-678a-08d86d75eeeb
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2020 23:40:55.8527
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZDsb81wKufnrdp4VC1r82nR5x2W8jMIIlWtR7GSmJ7IBW/mrl1abhouH7C5A/ccgscVWSt1O2pmNsShK8o+KMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4417
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-10-10 14:03:08, Ran Wang wrote:
> fsl_usb2_device_register() should stop init if dma_set_mask() return
> error.
>=20
> Fixes: cae058610465 ("drivers/usb/host: fsl: Set DMA_MASK of usb platform=
 device")
> Signed-off-by: Ran Wang <ran.wang_1@nxp.com>
> ---
>  drivers/usb/host/fsl-mph-dr-of.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-=
dr-of.c
> index ae8f60f..44a7e58 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -94,10 +94,13 @@ static struct platform_device *fsl_usb2_device_regist=
er(
> =20
>  	pdev->dev.coherent_dma_mask =3D ofdev->dev.coherent_dma_mask;
> =20
> -	if (!pdev->dev.dma_mask)
> +	if (!pdev->dev.dma_mask) {
>  		pdev->dev.dma_mask =3D &ofdev->dev.coherent_dma_mask;
> -	else
> -		dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> +	} else {
> +		retval =3D dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
> +		if (retval)
> +			goto error;
> +	}
> =20
>  	retval =3D platform_device_add_data(pdev, pdata, sizeof(*pdata));
>  	if (retval)
> --=20
> 2.7.4
>=20

Reviewed-by: Peter Chen <peter.chen@nxp.com>

One more place need to fix, if platform_device_alloc returns NULL,
it should not call platform_device_put to release platform
device memory.

	pdev =3D platform_device_alloc(name, id);
	if (!pdev) {
		retval =3D -ENOMEM;
		goto error;
	}
	...
error:
	platform_device_put(pdev);
	return ERR_PTR(retval);
--=20

Thanks,
Peter Chen=