Received: by 2002:a05:6a10:6744:0:0:0:0 with SMTP id w4csp3517640pxu; Sun, 11 Oct 2020 12:49:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNg7zMNsZhdH7x5d6IgQ3MIZ5hmTIRB7L8phnVO+LM11W/EC0W046o2PHc+bEiyccnef7n X-Received: by 2002:a17:906:2dd7:: with SMTP id h23mr25778158eji.175.1602445758838; Sun, 11 Oct 2020 12:49:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1602445758; cv=none; d=google.com; s=arc-20160816; b=e1Euq10R32Ds7KJPIg+LKSDfmkA3BIvRvu0076mOpRAvaMKpMF2jhWABw/m1svP4MW nLX8m8gECF9mBhVnK9uKRTHNyY9/iEtIwIyFRz4vf/Zm3CUVJ9Sf+ATdNIPSI0H347Wj sDydtMyTJmW080KQ4g5TKtwEg95+o2KlzcoNh9r6bG0+PM9oAO+vrcVM+dn9OJnv31FZ DXNfWFSaoL44kUU90l+xlpYhXY3lwutqJh+wlVrhT6ajF791v4f4qhr9jjRBeKjWOUbS wr13QQko9h6W6bS/Pt11hdcj7xnA8z3M1hRaxARExGKKwrVV77Qkyd4GIdOnsdJU+u7d 05tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qWkz3TadtHi8NNTObBGKxwM7sKTo6NT5Vznm23JWx0E=; b=rkJ/Vztzk/kMQ1doaprf4sHyTvlmY/r4poBjUZD1Sn8eXybRcQ2HNmjOv/rdnDf+o0 1+wcjVHBHY+oGEhEYu0Y0xI8DZfM73QUApowmb/vUAl+pKfKFNLPQwm1Q+B8+yKp1mnT n2l4UvxTQCGzSyGPIGnlh1DXBbHUrQwONm3ZMPNIfS23DdwhOBOfGNXWoTZYcuHNP/z/ kryOr8hXqK4XKEmMF9xrazcVyXG/2ZJPxgoOyPftTC+WBfj+sM5Un5Y43TqWjLQc4+rA dAaviONk3D8Eln41uusgsdtaDyYh5sABJRf2qpl9ZjRX3opmndtPZhudKyWtkoVlaTe2 Y5NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RB3m9jou; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b13si10484962edf.523.2020.10.11.12.48.56; Sun, 11 Oct 2020 12:49:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RB3m9jou; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387855AbgJKNFZ (ORCPT + 99 others); Sun, 11 Oct 2020 09:05:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387846AbgJKNFO (ORCPT ); Sun, 11 Oct 2020 09:05:14 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3552C0613CE; Sun, 11 Oct 2020 06:05:12 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id h6so11417255pgk.4; Sun, 11 Oct 2020 06:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qWkz3TadtHi8NNTObBGKxwM7sKTo6NT5Vznm23JWx0E=; b=RB3m9jouTQT1pND5bLLxoD+bk87PCZqjGlB3cgSeaIqOwri13ZfTAErn+1TqCNAL2X xWxruXunQ9708KmvaVSiDbxA72aa6kvPa6V42UgPGbzFI/WVZ8oosaculkf9vjWVffGo wyUYkKJowgztEaMDvSMz6i7qZLGyeRRsCKqT4trbYgm1t1O1inm4dy/HZZDqteG4q69L AnIuQK/N7yJb38UjwVp2bPKyBuOWXxkblUuqAA4VbM3h8BsHbi8aFTywTcpACEzVzIzV VuYFsX3lTOfd1yUJ8qY2CQ9EbpeRmOVuJYdO3YEqs47DLy9MWCkFDzr6EB/E9hNkBgOI 6yqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qWkz3TadtHi8NNTObBGKxwM7sKTo6NT5Vznm23JWx0E=; b=DznpXtvWzOMlTtwklMcWFAsgp6RSluC47vbyInxLMJB8eKBIrlPrLmGqPiVQViWEIn bpUZkpYlnjA+bnDLDLuLwnqEeAcZfc8isL66VBl6bAH51VE3tJ751M2gX1BYowxORAy5 Gl/u8OTJRMT4pXCh9Ff6/D+Xuoy98jfsK6UVkSBfqzj84AAdijIbK0SzauDucBJowBTh 8XXDIq3EePGK2AiVxuT1wqxJICqIgTKBJwqNQVjBe2r8ti8dnR2b6i/EZxSkIbOjQ4PK nVC6N4SFpywcq7XtLPhR7A6CMupyNio5qgo9Ukv99KPbAVFwdork0D/e3iU9YXxnQ0JA u5zA== X-Gm-Message-State: AOAM53388GYCHQUvgAiWi8wzHKG5jJujK+53cTdofyQZBVxAtSw+kWxa Kv30+nm0zxS+ScR8g+bg3Jkl/y/crQCA1r8M X-Received: by 2002:a65:684d:: with SMTP id q13mr8868635pgt.372.1602421512330; Sun, 11 Oct 2020 06:05:12 -0700 (PDT) Received: from localhost.localdomain (104.36.148.139.aurocloud.com. [104.36.148.139]) by smtp.gmail.com with ESMTPSA id r8sm18703663pgn.30.2020.10.11.06.05.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Oct 2020 06:05:11 -0700 (PDT) From: Rustam Kovhaev To: axboe@kernel.dk, linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Rustam Kovhaev Subject: [PATCH] block: switch to pr_warn() in __device_add_disk() Date: Sun, 11 Oct 2020 06:03:47 -0700 Message-Id: <20201011130347.562264-1-rkovhaev@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org syzbot triggered a warning while fuzzing with failslab fault injection enabled let's convert WARN_ON() to pr_warn() Reported-and-tested-by: syzbot+f41893bb8c45cd18cf08@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=f41893bb8c45cd18cf08 Signed-off-by: Rustam Kovhaev --- block/genhd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/genhd.c b/block/genhd.c index 99c64641c314..be9ce35cf0fe 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -822,7 +822,8 @@ static void __device_add_disk(struct device *parent, struct gendisk *disk, /* Register BDI before referencing it from bdev */ dev->devt = devt; ret = bdi_register(bdi, "%u:%u", MAJOR(devt), MINOR(devt)); - WARN_ON(ret); + if (ret) + pr_warn("%s: failed to register backing dev info\n", disk->disk_name); bdi_set_owner(bdi, dev); blk_register_region(disk_devt(disk), disk->minors, NULL, exact_match, exact_lock, disk); -- 2.28.0