Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Tianxianting <tian.xianting@h3c.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: Avoid allocing memory on memoryless numa node
Thread-Topic: [PATCH] net: Avoid allocing memory on memoryless numa node
Thread-Index: AQHWn4X33nOETvWn/EOdjwgvT00GhKmSQVKAgADYw6A=
Date:   Mon, 12 Oct 2020 00:14:39 +0000
Message-ID: <b77011b20e85434e8e5135ea1c0f51ac@h3c.com>
References: <20201011041140.8945-1-tian.xianting@h3c.com>
 <20201011121803.2c003c7e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20201011121803.2c003c7e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Precedence: bulk

Hi Jakub,
Thanks for your suggestion,
Let me try it :-)

-----Original Message-----
From: Jakub Kicinski [mailto:kuba@kernel.org] 
Sent: Monday, October 12, 2020 3:18 AM
To: tianxianting (RD) <tian.xianting@h3c.com>
Cc: davem@davemloft.net; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: Avoid allocing memory on memoryless numa node

On Sun, 11 Oct 2020 12:11:40 +0800 Xianting Tian wrote:
> In architecture like powerpc, we can have cpus without any local 
> memory attached to it. In such cases the node does not have real memory.
> 
> Use local_memory_node(), which is guaranteed to have memory.
> local_memory_node is a noop in other architectures that does not 
> support memoryless nodes.
> 
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> ---
>  net/core/dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c index 
> 266073e30..dcb4533ef 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2590,7 +2590,7 @@ static struct xps_map *expand_xps_map(struct xps_map *map, int attr_index,
>  		new_map = kzalloc(XPS_MAP_SIZE(alloc_len), GFP_KERNEL);
>  	else
>  		new_map = kzalloc_node(XPS_MAP_SIZE(alloc_len), GFP_KERNEL,
> -				       cpu_to_node(attr_index));
> +				       local_memory_node(cpu_to_node(attr_index)));
>  	if (!new_map)
>  		return NULL;
>  

Are we going to patch all kmalloc_node() callers now to apply local_memory_node()?  Can't the allocator take care of this?