Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Oct 2020 11:39:16 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     dmaengine@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dmaengine: add peripheral configuration
Message-ID: <20201012060916.GI2968@vkoul-mobl>
References: <20201008123151.764238-1-vkoul@kernel.org>
 <20201008123151.764238-3-vkoul@kernel.org>
 <e2c0323b-4f41-1926-5930-c63624fe1dd1@ti.com>
 <20201009103019.GD2968@vkoul-mobl>
 <a44af464-7d13-1254-54dd-f7783ccfaa0f@ti.com>
 <20201009111515.GF2968@vkoul-mobl>
 <13fdee71-5060-83fc-d69d-8ec73f82fac4@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13fdee71-5060-83fc-d69d-8ec73f82fac4@ti.com>
Precedence: bulk

On 09-10-20, 14:29, Peter Ujfalusi wrote:
> 
> 
> On 09/10/2020 14.15, Vinod Koul wrote:
> >>> If for any any reason subsequent txn is for different direction, I would
> >>> expect that parameters are set again before prep_ calls
> >>
> >> But in DEV_TO_DEV?
> > 
> > Do we support that :D
> > 
> >> If we have two peripherals, both needs config:
> >> p1_config and p2_config
> >>
> >> What and how would one use the single peripheral_config?
> > 
> > Since the config is implementation specific, I do not think it limits.
> > You may create
> > 
> > struct peter_config {
> >         struct p1_config;
> >         struct p2_config;
> > };
> 
> The use case is:
> MEM -DMA-> P1 -DMA-> P2
> or
> P2 -DMA-> P1 -DMA-> MEM
> or
> MEM -DMA-> P2
> or
> P2 -DMA-> MEM
> or
> MEM -DMA-> P1 -DMA-> MEM
> 
> How would the DMA guess what it should do? How would the independent P1
> and P2 would know how to set up the config?

As I said, we do not support DEV_TO_DEV yet :)

Question is how would p1<-->p2 look, will p1 initiate a DMA txn or p2..?
who will configure these..

Do you have a real world example in horizon...

-- 
~Vinod