Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1602229667-13165-1-git-send-email-Anson.Huang@nxp.com> <1602229667-13165-2-git-send-email-Anson.Huang@nxp.com>
In-Reply-To: <1602229667-13165-2-git-send-email-Anson.Huang@nxp.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Mon, 12 Oct 2020 08:53:40 +0200
Message-ID: <CAJKOXPeEnnOU_TYsO2svDCcZyMy7FPQyJkZzOWbDn7P8KhcZmg@mail.gmail.com>
Subject: Re: [PATCH 2/3] arm64: dts: imx8mn: Correct WDOG_B pin configuration
To:     Anson Huang <Anson.Huang@nxp.com>
Cc:     robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, aford173@gmail.com,
        daniel.baluta@nxp.com, shengjiu.wang@nxp.com, peter.chen@nxp.com,
        alifer.wsdm@gmail.com, abel.vesa@nxp.com, yibin.gong@nxp.com,
        jun.li@nxp.com, l.stach@pengutronix.de, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux-imx@nxp.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 9 Oct 2020 at 09:52, Anson Huang <Anson.Huang@nxp.com> wrote:
>
> Different revision of i.MX8MN EVK boards may have different external
> pull up registor design, some are enabled while some are NOT, to make
> sure the WDOG_B pin works properly, better to enable internal pull up
> resistor. Since enabling internal pull up resistor is NOT harmful and
> having benefit of flexibility on different board design, just enable
> it for all i.MX8MN boards.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi     | 2 +-
>  arch/arm64/boot/dts/freescale/imx8mn-var-som.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

The same as patch #1 - you do more than just enable pull up.

Best regards,
Krzysztof