Date: Wed, 9 Aug 2006 22:38:28 -0700
From: Greg KH <greg@kroah.com>
To: Eric Sandeen <esandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, Greg KH <gregkh@suse.de>,
       linux-kernel@vger.kernel.org, stable@kernel.org, torvalds@osdl.org,
       Justin Forbes <jmforbes@linuxtx.org>,
       Zwane Mwaikambo <zwane@arm.linux.org.uk>,
       "Theodore Ts'o" <tytso@mit.edu>, Randy Dunlap <rdunlap@xenotime.net>,
       Dave Jones <davej@redhat.com>, Chuck Wolber <chuckw@quantumlinux.com>,
       Chris Wedgwood <reviews@ml.cw.f00f.org>, akpm@osdl.org,
       alan@lxorguk.ukuu.org.uk, jack@suse.cz, neilb@suse.de,
       Marcel Holtmann <marcel@holtmann.org>,
       "Stephen C. Tweedie" <sct@redhat.com>
Subject: Re: [stable] [patch 16/23] ext3: avoid triggering ext3_error on bad NFS file handle
Message-ID: <20060810053828.GA14987@kroah.com>
References: <20060804053258.391158155@quad.kroah.org> <20060804054010.GQ769@kroah.com> <44D35DA0.4060403@redhat.com> <20060804145254.GA20640@infradead.org> <44D36946.7020601@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <44D36946.7020601@redhat.com>
User-Agent: Mutt/1.5.12-2006-07-14
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1796
Lines: 43

On Fri, Aug 04, 2006 at 10:35:34AM -0500, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> >On Fri, Aug 04, 2006 at 09:45:52AM -0500, Eric Sandeen wrote:
> >>Greg KH wrote:
> >>>-stable review patch.  If anyone has any objections, please let us know.
> >>>
> >>>------------------
> >>>From: Neil Brown <neilb@suse.de>
> >>>
> >>>The inode number out of an NFS file handle gets passed eventually to
> >>>ext3_get_inode_block() without any checking.  If ext3_get_inode_block()
> >>>allows it to trigger an error, then bad filehandles can have unpleasant
> >>>effect - ext3_error() will usually cause a forced read-only remount, or a
> >>>panic if `errors=panic' was used.
> >>>
> >>>So remove the call to ext3_error there and put a matching check in
> >>>ext3/namei.c where inode numbers are read off storage.
> >>This patch and the ext2 patch (23/23) are accomplishing the same thing in 
> >>2 different ways, I think, and introducing unnecessary differences 
> >>between ext2 and ext3.  I'd personally prefer to see both ext2 and ext3 
> >>handled with the get_dentry op addition, and I'd be happy to quickly whip 
> >>up the ext3 patch to do this if there's agreement on this path.
> >
> >I completly agree with Eric here.  Also pushing out only the fix for one
> >(and today probably the lesser used) filesystems to -stable seems wrong.
> 
> so how's this? (compile tested)
> 
> Thanks,
> -Eric

> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> 
> (tho blatantly ripped off from Neil Brown's ext2 patch)

Thanks, I've queued this up.

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/