Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201010221806.2106-1-amonakov@ispras.ru> <CAJZ5v0iFj0s=ZNrLnBxQ34uUnn2NQ6bH+oriyNWrFu-g8HGfUg@mail.gmail.com>
 <alpine.LNX.2.20.13.2010121410490.15808@monopod.intra.ispras.ru>
In-Reply-To: <alpine.LNX.2.20.13.2010121410490.15808@monopod.intra.ispras.ru>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Mon, 12 Oct 2020 13:32:05 +0200
Message-ID: <CAJZ5v0jzebmUJ8zYzCU1W08POdE7=+Uu5DGGjJaZLsp06+=YAw@mail.gmail.com>
Subject: Re: [PATCH] intel_idle: mention assumption that wbinvd is not needed
To:     Alexander Monakov <amonakov@ispras.ru>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Oct 12, 2020 at 1:14 PM Alexander Monakov <amonakov@ispras.ru> wrote:
>
> On Mon, 12 Oct 2020, Rafael J. Wysocki wrote:
>
> > > @@ -20,7 +20,11 @@
> > >   * All CPUs have same idle states as boot CPU
> > >   *
> > >   * Chipset BM_STS (bus master status) bit is a NOP
> > > - *     for preventing entry into deep C-stats
> > > + *     for preventing entry into deep C-states
> > > + *
> > > + * CPU will flush caches as needed when entering a C-state via MWAIT
> >
> > I would rephrase this to mention that the above actually is an assumption.
>
> This comment block is by itself a list of assumptions.

Ah, OK

> It begins with heading
> "Design Assumptions" and then lists two assumptions. This patch adds a third
> one.
>
> With that clarified, do you still need me to change this hunk?

No need.